aboutsummaryrefslogtreecommitdiffhomepage
path: root/http/client/response_test.go
blob: 6a2d8c214acdb68ae64cad1bc6ffb8d76e64a5e3 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
// Copyright 2017 Frédéric Guillot. All rights reserved.
// Use of this source code is governed by the Apache 2.0
// license that can be found in the LICENSE file.

package client // import "miniflux.app/http/client"

import (
	"bytes"
	"io/ioutil"
	"strings"
	"testing"
	"unicode/utf8"
)

func TestIsNotFound(t *testing.T) {
	scenarios := map[int]bool{
		200: false,
		404: true,
		410: true,
	}

	for input, expected := range scenarios {
		r := &Response{StatusCode: input}
		actual := r.IsNotFound()

		if actual != expected {
			t.Errorf(`Unexpected result, got %v instead of %v for status code %d`, actual, expected, input)
		}
	}
}

func TestIsNotAuthorized(t *testing.T) {
	scenarios := map[int]bool{
		200: false,
		401: true,
		403: false,
	}

	for input, expected := range scenarios {
		r := &Response{StatusCode: input}
		actual := r.IsNotAuthorized()

		if actual != expected {
			t.Errorf(`Unexpected result, got %v instead of %v for status code %d`, actual, expected, input)
		}
	}
}

func TestHasServerFailure(t *testing.T) {
	scenarios := map[int]bool{
		200: false,
		404: true,
		500: true,
	}

	for input, expected := range scenarios {
		r := &Response{StatusCode: input}
		actual := r.HasServerFailure()

		if actual != expected {
			t.Errorf(`Unexpected result, got %v instead of %v for status code %d`, actual, expected, input)
		}
	}
}

func TestIsModifiedWith304Status(t *testing.T) {
	r := &Response{StatusCode: 304}
	if r.IsModified("etag", "lastModified") {
		t.Error("The resource should not be considered modified")
	}
}

func TestIsModifiedWithIdenticalEtag(t *testing.T) {
	r := &Response{StatusCode: 200, ETag: "etag"}
	if r.IsModified("etag", "lastModified") {
		t.Error("The resource should not be considered modified")
	}
}

func TestIsModifiedWithIdenticalLastModified(t *testing.T) {
	r := &Response{StatusCode: 200, LastModified: "lastModified"}
	if r.IsModified("etag", "lastModified") {
		t.Error("The resource should not be considered modified")
	}
}

func TestIsModifiedWithDifferentHeaders(t *testing.T) {
	r := &Response{StatusCode: 200, ETag: "some etag", LastModified: "some date"}
	if !r.IsModified("etag", "lastModified") {
		t.Error("The resource should be considered modified")
	}
}

func TestToString(t *testing.T) {
	input := `test`
	r := &Response{Body: strings.NewReader(input)}

	if r.BodyAsString() != input {
		t.Error(`Unexpected ouput`)
	}
}

func TestEnsureUnicodeWithHTMLDocuments(t *testing.T) {
	var unicodeTestCases = []struct {
		filename, contentType string
		convertedToUnicode    bool
	}{
		{"HTTP-charset.html", "text/html; charset=iso-8859-15", true},
		{"UTF-16LE-BOM.html", "", true},
		{"UTF-16BE-BOM.html", "", true},
		{"meta-content-attribute.html", "text/html", true},
		{"meta-charset-attribute.html", "text/html", true},
		{"No-encoding-declaration.html", "text/html", true},
		{"HTTP-vs-UTF-8-BOM.html", "text/html; charset=iso-8859-15", true},
		{"HTTP-vs-meta-content.html", "text/html; charset=iso-8859-15", true},
		{"HTTP-vs-meta-charset.html", "text/html; charset=iso-8859-15", true},
		{"UTF-8-BOM-vs-meta-content.html", "text/html", true},
		{"UTF-8-BOM-vs-meta-charset.html", "text/html", true},
		{"windows_1251.html", "text/html; charset=windows-1251", true},
		{"gb2312.html", "text/html", true},
		{"urdu.xml", "text/xml; charset=utf-8", true},
		{"content-type-only-win-8859-1.xml", "application/xml; charset=ISO-8859-1", true},
		{"rdf_utf8.xml", "application/rss+xml; charset=utf-8", true},
		{"rdf_utf8.xml", "application/rss+xml; charset: utf-8", true}, // Invalid Content-Type
		{"charset-content-type-xml-iso88591.xml", "application/rss+xml; charset=ISO-8859-1", false},
		{"windows_1251.xml", "text/xml", false},
		{"smallfile.xml", "text/xml; charset=utf-8", true},
		{"single_quote_xml_encoding.xml", "text/xml; charset=utf-8", true},
	}

	for _, tc := range unicodeTestCases {
		content, err := ioutil.ReadFile("testdata/" + tc.filename)
		if err != nil {
			t.Fatalf(`Unable to read file %q: %v`, tc.filename, err)
		}

		r := &Response{Body: bytes.NewReader(content), ContentType: tc.contentType}
		parseErr := r.EnsureUnicodeBody()
		if parseErr != nil {
			t.Fatalf(`Unicode conversion error for %q - %q: %v`, tc.filename, tc.contentType, parseErr)
		}

		isUnicode := utf8.ValidString(r.BodyAsString())
		if isUnicode != tc.convertedToUnicode {
			t.Errorf(`Unicode conversion %q - %q, got: %v, expected: %v`,
				tc.filename, tc.contentType, isUnicode, tc.convertedToUnicode)
		}
	}
}