diff options
author | Frédéric Guillot <fred@miniflux.net> | 2019-09-10 21:12:38 -0700 |
---|---|---|
committer | Frédéric Guillot <fred@miniflux.net> | 2019-09-10 21:22:19 -0700 |
commit | 8d8f78241d303381abf6879cc007ca9cbc2a12e2 (patch) | |
tree | 9c6b8028bd0ff04e2fc6b26992c6de61336b10be /reader | |
parent | 937492f6f554d51d8cae62829b6229071cac994e (diff) |
Add native lazy loading for images and iframes
This feature is available only in Chrome >= 76 for now.
See https://web.dev/native-lazy-loading
Diffstat (limited to 'reader')
-rw-r--r-- | reader/sanitizer/sanitizer.go | 4 | ||||
-rw-r--r-- | reader/sanitizer/sanitizer_test.go | 20 |
2 files changed, 13 insertions, 11 deletions
diff --git a/reader/sanitizer/sanitizer.go b/reader/sanitizer/sanitizer.go index 1065e5b..642fedf 100644 --- a/reader/sanitizer/sanitizer.go +++ b/reader/sanitizer/sanitizer.go @@ -137,7 +137,9 @@ func getExtraAttributes(tagName string) ([]string, []string) { case "video", "audio": return []string{"controls"}, []string{"controls"} case "iframe": - return []string{"sandbox"}, []string{`sandbox="allow-scripts allow-same-origin allow-popups"`} + return []string{"sandbox", "loading"}, []string{`sandbox="allow-scripts allow-same-origin allow-popups"`, `loading="lazy"`} + case "img": + return []string{"loading"}, []string{`loading="lazy"`} default: return nil, nil } diff --git a/reader/sanitizer/sanitizer_test.go b/reader/sanitizer/sanitizer_test.go index 57769dd..649b7f0 100644 --- a/reader/sanitizer/sanitizer_test.go +++ b/reader/sanitizer/sanitizer_test.go @@ -7,7 +7,7 @@ package sanitizer // import "miniflux.app/reader/sanitizer" import "testing" func TestValidInput(t *testing.T) { - input := `<p>This is a <strong>text</strong> with an image: <img src="http://example.org/" alt="Test">.</p>` + input := `<p>This is a <strong>text</strong> with an image: <img src="http://example.org/" alt="Test" loading="lazy">.</p>` output := Sanitize("http://example.org/", input) if input != output { @@ -16,7 +16,7 @@ func TestValidInput(t *testing.T) { } func TestSelfClosingTags(t *testing.T) { - input := `<p>This <br> is a <strong>text</strong> <br/>with an image: <img src="http://example.org/" alt="Test"/>.</p>` + input := `<p>This <br> is a <strong>text</strong> <br/>with an image: <img src="http://example.org/" alt="Test" loading="lazy"/>.</p>` output := Sanitize("http://example.org/", input) if input != output { @@ -35,7 +35,7 @@ func TestTable(t *testing.T) { func TestRelativeURL(t *testing.T) { input := `This <a href="/test.html">link is relative</a> and this image: <img src="../folder/image.png"/>` - expected := `This <a href="http://example.org/test.html" rel="noopener noreferrer" target="_blank" referrerpolicy="no-referrer">link is relative</a> and this image: <img src="http://example.org/folder/image.png"/>` + expected := `This <a href="http://example.org/test.html" rel="noopener noreferrer" target="_blank" referrerpolicy="no-referrer">link is relative</a> and this image: <img src="http://example.org/folder/image.png" loading="lazy"/>` output := Sanitize("http://example.org/", input) if expected != output { @@ -165,7 +165,7 @@ func TestEspaceAttributes(t *testing.T) { func TestReplaceYoutubeURL(t *testing.T) { input := `<iframe src="http://www.youtube.com/embed/test123?version=3&rel=1&fs=1&autohide=2&showsearch=0&showinfo=1&iv_load_policy=1&wmode=transparent"></iframe>` - expected := `<iframe src="https://www.youtube-nocookie.com/embed/test123?version=3&rel=1&fs=1&autohide=2&showsearch=0&showinfo=1&iv_load_policy=1&wmode=transparent" sandbox="allow-scripts allow-same-origin allow-popups"></iframe>` + expected := `<iframe src="https://www.youtube-nocookie.com/embed/test123?version=3&rel=1&fs=1&autohide=2&showsearch=0&showinfo=1&iv_load_policy=1&wmode=transparent" sandbox="allow-scripts allow-same-origin allow-popups" loading="lazy"></iframe>` output := Sanitize("http://example.org/", input) if expected != output { @@ -175,7 +175,7 @@ func TestReplaceYoutubeURL(t *testing.T) { func TestReplaceSecureYoutubeURL(t *testing.T) { input := `<iframe src="https://www.youtube.com/embed/test123"></iframe>` - expected := `<iframe src="https://www.youtube-nocookie.com/embed/test123" sandbox="allow-scripts allow-same-origin allow-popups"></iframe>` + expected := `<iframe src="https://www.youtube-nocookie.com/embed/test123" sandbox="allow-scripts allow-same-origin allow-popups" loading="lazy"></iframe>` output := Sanitize("http://example.org/", input) if expected != output { @@ -185,7 +185,7 @@ func TestReplaceSecureYoutubeURL(t *testing.T) { func TestReplaceSecureYoutubeURLWithParameters(t *testing.T) { input := `<iframe src="https://www.youtube.com/embed/test123?rel=0&controls=0"></iframe>` - expected := `<iframe src="https://www.youtube-nocookie.com/embed/test123?rel=0&controls=0" sandbox="allow-scripts allow-same-origin allow-popups"></iframe>` + expected := `<iframe src="https://www.youtube-nocookie.com/embed/test123?rel=0&controls=0" sandbox="allow-scripts allow-same-origin allow-popups" loading="lazy"></iframe>` output := Sanitize("http://example.org/", input) if expected != output { @@ -195,7 +195,7 @@ func TestReplaceSecureYoutubeURLWithParameters(t *testing.T) { func TestReplaceYoutubeURLAlreadyReplaced(t *testing.T) { input := `<iframe src="https://www.youtube-nocookie.com/embed/test123?rel=0&controls=0" sandbox="allow-scripts allow-same-origin"></iframe>` - expected := `<iframe src="https://www.youtube-nocookie.com/embed/test123?rel=0&controls=0" sandbox="allow-scripts allow-same-origin allow-popups"></iframe>` + expected := `<iframe src="https://www.youtube-nocookie.com/embed/test123?rel=0&controls=0" sandbox="allow-scripts allow-same-origin allow-popups" loading="lazy"></iframe>` output := Sanitize("http://example.org/", input) if expected != output { @@ -205,7 +205,7 @@ func TestReplaceYoutubeURLAlreadyReplaced(t *testing.T) { func TestReplaceProtocolRelativeYoutubeURL(t *testing.T) { input := `<iframe src="//www.youtube.com/embed/Bf2W84jrGqs" width="560" height="314" allowfullscreen="allowfullscreen"></iframe>` - expected := `<iframe src="https://www.youtube-nocookie.com/embed/Bf2W84jrGqs" width="560" height="314" allowfullscreen="allowfullscreen" sandbox="allow-scripts allow-same-origin allow-popups"></iframe>` + expected := `<iframe src="https://www.youtube-nocookie.com/embed/Bf2W84jrGqs" width="560" height="314" allowfullscreen="allowfullscreen" sandbox="allow-scripts allow-same-origin allow-popups" loading="lazy"></iframe>` output := Sanitize("http://example.org/", input) if expected != output { @@ -215,7 +215,7 @@ func TestReplaceProtocolRelativeYoutubeURL(t *testing.T) { func TestReplaceIframeURL(t *testing.T) { input := `<iframe src="https://player.vimeo.com/video/123456?title=0&byline=0"></iframe>` - expected := `<iframe src="https://player.vimeo.com/video/123456?title=0&byline=0" sandbox="allow-scripts allow-same-origin allow-popups"></iframe>` + expected := `<iframe src="https://player.vimeo.com/video/123456?title=0&byline=0" sandbox="allow-scripts allow-same-origin allow-popups" loading="lazy"></iframe>` output := Sanitize("http://example.org/", input) if expected != output { @@ -224,7 +224,7 @@ func TestReplaceIframeURL(t *testing.T) { } func TestReplaceNoScript(t *testing.T) { - input := `<p>Before paragraph.</p><noscript>Inside <code>noscript</code> tag with an image: <img src="http://example.org/" alt="Test"></noscript><p>After paragraph.</p>` + input := `<p>Before paragraph.</p><noscript>Inside <code>noscript</code> tag with an image: <img src="http://example.org/" alt="Test" loading="lazy"></noscript><p>After paragraph.</p>` expected := `<p>Before paragraph.</p><p>After paragraph.</p>` output := Sanitize("http://example.org/", input) |