aboutsummaryrefslogtreecommitdiffhomepage
path: root/reader/rewrite/rewrite_functions.go
diff options
context:
space:
mode:
authorGravatar dzaikos <you@example.com>2018-06-26 17:39:56 -0400
committerGravatar dzaikos <you@example.com>2018-06-26 17:50:18 -0400
commit45d7105ed15dd80c9fdd76f61cf239b0a6177a4c (patch)
treee0f028045a4f53ba1c6155e99affb0e58d73eefc /reader/rewrite/rewrite_functions.go
parentc9131b0e89db2989dd5e2e6894d6bec6c0075cb6 (diff)
Refactor AddImageTitle rewriter.
* Only processes images with `src` **and** `title` attributes (others are ignored). * Processes **all** images in the document (not just the first one). * Wraps the image and its title attribute in a `figure` tag with the title attribute's contents in a `figcaption` tag. Updated xkcd rewriter unit test. Added another xkcd rewriter unit test to check rendering of images without title tags.
Diffstat (limited to 'reader/rewrite/rewrite_functions.go')
-rw-r--r--reader/rewrite/rewrite_functions.go16
1 files changed, 13 insertions, 3 deletions
diff --git a/reader/rewrite/rewrite_functions.go b/reader/rewrite/rewrite_functions.go
index 6717deb..412266d 100644
--- a/reader/rewrite/rewrite_functions.go
+++ b/reader/rewrite/rewrite_functions.go
@@ -22,9 +22,19 @@ func addImageTitle(entryURL, entryContent string) string {
return entryContent
}
- imgTag := doc.Find("img").First()
- if titleAttr, found := imgTag.Attr("title"); found {
- return entryContent + `<blockquote cite="` + entryURL + `">` + titleAttr + "</blockquote>"
+ matches := doc.Find("img[src][title]")
+
+ if matches.Length() > 0 {
+ matches.Each(func(i int, img *goquery.Selection) {
+ altAttr := img.AttrOr("alt", "")
+ srcAttr, _ := img.Attr("src")
+ titleAttr, _ := img.Attr("title")
+
+ img.ReplaceWithHtml(`<figure><img src="` + srcAttr + `" alt="` + altAttr + `"/><figcaption><p>` + titleAttr + `</p></figcaption></figure>`)
+ })
+
+ output, _ := doc.Find("body").First().Html()
+ return output
}
return entryContent