diff options
author | Frédéric Guillot <fred@miniflux.net> | 2019-12-26 15:26:23 -0800 |
---|---|---|
committer | Frédéric Guillot <fred@miniflux.net> | 2019-12-26 15:56:59 -0800 |
commit | 3debf75eb9229144a05701e03ba59408a75dd815 (patch) | |
tree | 9e9eb6569db3234b514f798d4278b20793b79833 /reader/feed/handler.go | |
parent | 200b1c304b999191a29f36d4122e7aa05481125c (diff) |
Normalize URL query string before executing HTTP requests
- Make sure query strings parameters are encoded
- As opposed to the standard library, do not append equal sign
for query parameters with empty value
- Strip URL fragments like Web browsers
Diffstat (limited to 'reader/feed/handler.go')
-rw-r--r-- | reader/feed/handler.go | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/reader/feed/handler.go b/reader/feed/handler.go index b272ea1..7dd0bc7 100644 --- a/reader/feed/handler.go +++ b/reader/feed/handler.go @@ -52,7 +52,7 @@ func (h *Handler) CreateFeed(userID, categoryID int64, url string, crawler bool, return nil, errors.NewLocalizedError(errDuplicate, response.EffectiveURL) } - subscription, parseErr := parser.ParseFeed(response.String()) + subscription, parseErr := parser.ParseFeed(response.BodyAsString()) if parseErr != nil { return nil, parseErr } @@ -106,7 +106,7 @@ func (h *Handler) RefreshFeed(userID, feedID int64) error { if response.IsModified(originalFeed.EtagHeader, originalFeed.LastModifiedHeader) { logger.Debug("[Handler:RefreshFeed] Feed #%d has been modified", feedID) - updatedFeed, parseErr := parser.ParseFeed(response.String()) + updatedFeed, parseErr := parser.ParseFeed(response.BodyAsString()) if parseErr != nil { originalFeed.WithError(parseErr.Localize(printer)) h.store.UpdateFeedError(originalFeed) |