diff options
| author |  serjepatoff <SerjEpatoff@gmail.com> | 2016-09-13 23:29:21 +0400 |
|---|---|---|
| committer |  Hoà V. DINH <dinh.viet.hoa@gmail.com> | 2016-09-13 12:29:21 -0700 |
| commit | f708ce74e23b61ec6e5ae958eba0b8bcd8831a1e (patch) | |
| tree | 4baeae41294d8d320723bfcc10b7baa3a0707cb9 | |
| parent | 7eeb60a8b42cddcd4e61d299c8037cbb22eb63ba (diff) | |
MCIMAPCheckAccountOperation: connectIfNeeded() then login() sequence of calls is error-prone. Single loginIfNeeded() is better. (#1509)
| -rw-r--r-- | src/async/imap/MCIMAPCheckAccountOperation.cpp | 11 |
1 files changed, 4 insertions, 7 deletions
diff --git a/src/async/imap/MCIMAPCheckAccountOperation.cpp b/src/async/imap/MCIMAPCheckAccountOperation.cpp index 64e9a51a..87e6a705 100644 --- a/src/async/imap/MCIMAPCheckAccountOperation.cpp +++ b/src/async/imap/MCIMAPCheckAccountOperation.cpp @@ -28,13 +28,10 @@ IMAPCheckAccountOperation::~IMAPCheckAccountOperation() void IMAPCheckAccountOperation::main() { ErrorCode error; - session()->session()->connectIfNeeded(&error); - if (error == ErrorNone) { - session()->session()->login(&error); - if (error != ErrorNone) { - MC_SAFE_REPLACE_COPY(String, mLoginResponse, session()->session()->loginResponse()); - MC_SAFE_REPLACE_COPY(Data, mLoginUnparsedResponseData, session()->session()->unparsedResponseData()); - } + session()->session()->loginIfNeeded(&error); + if (error != ErrorNone) { + MC_SAFE_REPLACE_COPY(String, mLoginResponse, session()->session()->loginResponse()); + MC_SAFE_REPLACE_COPY(Data, mLoginUnparsedResponseData, session()->session()->unparsedResponseData()); } setError(error); } |