diff options
author | 2015-12-29 15:42:16 -0500 | |
---|---|---|
committer | 2015-12-29 15:42:16 -0500 | |
commit | b0635b9e8f3ba3b48d1335b95ff32bd1731d74b5 (patch) | |
tree | 1a02da292f1fc626dac0a7978a4229a8086dae72 | |
parent | 0a06951d94e560268811c5f004574e56ba2c3e94 (diff) |
Follow suggestions from @dinhviethoa.
Follow suggestions to remove one unnecessary overload and to mark other
as depreciated. (A third suggestion was covered by another commit.)
-rw-r--r-- | src/core/nntp/MCNNTPSession.cpp | 5 | ||||
-rw-r--r-- | src/core/nntp/MCNNTPSession.h | 1 | ||||
-rw-r--r-- | src/objc/nntp/MCONNTPSession.h | 2 |
3 files changed, 1 insertions, 7 deletions
diff --git a/src/core/nntp/MCNNTPSession.cpp b/src/core/nntp/MCNNTPSession.cpp index bc86ebbc..933f10f2 100644 --- a/src/core/nntp/MCNNTPSession.cpp +++ b/src/core/nntp/MCNNTPSession.cpp @@ -493,11 +493,6 @@ Data * NNTPSession::fetchArticleByMessageID(String * messageID, ErrorCode * pErr return result; } -Data * NNTPSession::fetchArticleByMessageID(String * groupName, String * messageID, ErrorCode * pError) -{ - return this->fetchArticleByMessageID(messageID, pError); -} - time_t NNTPSession::fetchServerDate(ErrorCode * pError) { int r; struct tm time; diff --git a/src/core/nntp/MCNNTPSession.h b/src/core/nntp/MCNNTPSession.h index c39cf727..ec0080ed 100644 --- a/src/core/nntp/MCNNTPSession.h +++ b/src/core/nntp/MCNNTPSession.h @@ -54,7 +54,6 @@ namespace mailcore { virtual Data * fetchArticle(String *groupName, unsigned int index, NNTPProgressCallback * callback, ErrorCode * pError); virtual Data * fetchArticleByMessageID(String * messageID, ErrorCode * pError); - virtual Data * fetchArticleByMessageID(String * groupname, String * messageID, ErrorCode * pError); virtual time_t fetchServerDate(ErrorCode * pError); diff --git a/src/objc/nntp/MCONNTPSession.h b/src/objc/nntp/MCONNTPSession.h index 6b540947..ce382577 100644 --- a/src/objc/nntp/MCONNTPSession.h +++ b/src/objc/nntp/MCONNTPSession.h @@ -153,7 +153,7 @@ // messageData is the RFC 822 formatted message data. }]; */ -- (MCONNTPFetchArticleOperation *) fetchArticleOperationWithMessageID:(NSString *)messageID inGroup:(NSString * __nullable)group; +- (MCONNTPFetchArticleOperation *) fetchArticleOperationWithMessageID:(NSString *)messageID inGroup:(NSString * __nullable)group DEPRECATED_ATTRIBUTE; /** Returns an operation that will fetch the server's date and time. |