diff options
Diffstat (limited to 'tools/run_tests/sanity/core_banned_functions.py')
| -rwxr-xr-x | tools/run_tests/sanity/core_banned_functions.py | 51 |
1 files changed, 30 insertions, 21 deletions
diff --git a/tools/run_tests/sanity/core_banned_functions.py b/tools/run_tests/sanity/core_banned_functions.py index 989990542e..1d3f2eba8a 100755 --- a/tools/run_tests/sanity/core_banned_functions.py +++ b/tools/run_tests/sanity/core_banned_functions.py @@ -23,35 +23,39 @@ os.chdir(os.path.join(os.path.dirname(sys.argv[0]), '../../..')) # map of banned function signature to whitelist BANNED_EXCEPT = { - 'grpc_resource_quota_ref(': ['src/core/lib/iomgr/resource_quota.c'], - 'grpc_resource_quota_unref(': ['src/core/lib/iomgr/resource_quota.c'], - 'grpc_slice_buffer_destroy(': ['src/core/lib/slice/slice_buffer.c'], - 'grpc_slice_buffer_reset_and_unref(': ['src/core/lib/slice/slice_buffer.c'], - 'grpc_slice_ref(': ['src/core/lib/slice/slice.c'], - 'grpc_slice_unref(': ['src/core/lib/slice/slice.c'], - 'grpc_error_create(': ['src/core/lib/iomgr/error.c'], - 'grpc_error_ref(': ['src/core/lib/iomgr/error.c'], - 'grpc_error_unref(': ['src/core/lib/iomgr/error.c'], - 'grpc_os_error(': ['src/core/lib/iomgr/error.c'], - 'grpc_wsa_error(': ['src/core/lib/iomgr/error.c'], - 'grpc_log_if_error(': ['src/core/lib/iomgr/error.c'], - 'grpc_slice_malloc(': ['src/core/lib/slice/slice.c'], - 'grpc_closure_create(': ['src/core/lib/iomgr/closure.c'], - 'grpc_closure_init(': ['src/core/lib/iomgr/closure.c'], - 'grpc_closure_sched(': ['src/core/lib/iomgr/closure.c'], - 'grpc_closure_run(': ['src/core/lib/iomgr/closure.c'], - 'grpc_closure_list_sched(': ['src/core/lib/iomgr/closure.c'], + 'grpc_resource_quota_ref(': ['src/core/lib/iomgr/resource_quota.cc'], + 'grpc_resource_quota_unref(': ['src/core/lib/iomgr/resource_quota.cc'], + 'grpc_slice_buffer_destroy(': ['src/core/lib/slice/slice_buffer.cc'], + 'grpc_slice_buffer_reset_and_unref(': + ['src/core/lib/slice/slice_buffer.cc'], + 'grpc_slice_ref(': ['src/core/lib/slice/slice.cc'], + 'grpc_slice_unref(': ['src/core/lib/slice/slice.cc'], + 'grpc_error_create(': ['src/core/lib/iomgr/error.cc'], + 'grpc_error_ref(': ['src/core/lib/iomgr/error.cc'], + 'grpc_error_unref(': ['src/core/lib/iomgr/error.cc'], + 'grpc_os_error(': ['src/core/lib/iomgr/error.cc'], + 'grpc_wsa_error(': ['src/core/lib/iomgr/error.cc'], + 'grpc_log_if_error(': ['src/core/lib/iomgr/error.cc'], + 'grpc_slice_malloc(': ['src/core/lib/slice/slice.cc'], + 'grpc_closure_create(': ['src/core/lib/iomgr/closure.cc'], + 'grpc_closure_init(': ['src/core/lib/iomgr/closure.cc'], + 'grpc_closure_sched(': ['src/core/lib/iomgr/closure.cc'], + 'grpc_closure_run(': ['src/core/lib/iomgr/closure.cc'], + 'grpc_closure_list_sched(': ['src/core/lib/iomgr/closure.cc'], 'gpr_getenv_silent(': [ - 'src/core/lib/gpr/log.c', 'src/core/lib/gpr/env_linux.c', - 'src/core/lib/gpr/env_posix.c', 'src/core/lib/gpr/env_windows.c' + 'src/core/lib/gpr/log.cc', 'src/core/lib/gpr/env_linux.cc', + 'src/core/lib/gpr/env_posix.cc', 'src/core/lib/gpr/env_windows.cc' ], } errors = 0 +num_files = 0 for root, dirs, files in os.walk('src/core'): + if root.startswith('src/core/tsi'): continue for filename in files: + num_files += 1 path = os.path.join(root, filename) - if os.path.splitext(path)[1] != '.c': continue + if os.path.splitext(path)[1] != '.cc': continue with open(path) as f: text = f.read() for banned, exceptions in BANNED_EXCEPT.items(): @@ -61,3 +65,8 @@ for root, dirs, files in os.walk('src/core'): errors += 1 assert errors == 0 +# This check comes about from this issue: +# https://github.com/grpc/grpc/issues/15381 +# Basically, a change rendered this script useless and we did not realize it. +# This dumb check ensures that this type of issue doesn't occur again. +assert num_files > 300 # we definitely have more than 300 files |