aboutsummaryrefslogtreecommitdiffhomepage
path: root/test/core/channel/channelz_test.cc
diff options
context:
space:
mode:
Diffstat (limited to 'test/core/channel/channelz_test.cc')
-rw-r--r--test/core/channel/channelz_test.cc42
1 files changed, 7 insertions, 35 deletions
diff --git a/test/core/channel/channelz_test.cc b/test/core/channel/channelz_test.cc
index b8e65ebfb3..ec1c9f6faf 100644
--- a/test/core/channel/channelz_test.cc
+++ b/test/core/channel/channelz_test.cc
@@ -44,16 +44,17 @@ namespace channelz {
namespace testing {
// testing peer to access channel internals
-class ChannelNodePeer {
+class CallCountingAndTracingNodePeer {
public:
- ChannelNodePeer(ChannelNode* channel) : channel_(channel) {}
+ CallCountingAndTracingNodePeer(CallCountingAndTracingNode* node)
+ : node_(node) {}
grpc_millis last_call_started_millis() {
return (grpc_millis)gpr_atm_no_barrier_load(
- &channel_->last_call_started_millis_);
+ &node_->last_call_started_millis_);
}
private:
- ChannelNode* channel_;
+ CallCountingAndTracingNode* node_;
};
namespace {
@@ -163,16 +164,8 @@ void ValidateChannel(ChannelNode* channel, validate_channel_data_args args) {
gpr_free(core_api_json_str);
}
-void ValidateSubchannel(SubchannelNode* subchannel,
- validate_channel_data_args args) {
- char* json_str = subchannel->RenderJsonString();
- grpc::testing::ValidateSubchannelProtoJsonTranslation(json_str);
- ValidateCounters(json_str, args);
- gpr_free(json_str);
-}
-
-grpc_millis GetLastCallStartedMillis(ChannelNode* channel) {
- ChannelNodePeer peer(channel);
+grpc_millis GetLastCallStartedMillis(CallCountingAndTracingNode* channel) {
+ CallCountingAndTracingNodePeer peer(channel);
return peer.last_call_started_millis();
}
@@ -283,29 +276,8 @@ TEST(ChannelzGetTopChannelsTest, InternalChannelTest) {
grpc_channel_destroy(internal_channel);
}
-class ChannelzSubchannelTest : public ::testing::TestWithParam<size_t> {};
-
-TEST_P(ChannelzSubchannelTest, BasicTest) {
- grpc_core::ExecCtx exec_ctx;
- RefCountedPtr<SubchannelNode> channelz_subchannel =
- MakeRefCounted<SubchannelNode>(GetParam());
- channelz_subchannel->RecordCallStarted();
- channelz_subchannel->RecordCallFailed();
- channelz_subchannel->RecordCallSucceeded();
- ValidateSubchannel(channelz_subchannel.get(), {1, 1, 1});
- channelz_subchannel->RecordCallStarted();
- channelz_subchannel->RecordCallFailed();
- channelz_subchannel->RecordCallSucceeded();
- channelz_subchannel->RecordCallStarted();
- channelz_subchannel->RecordCallFailed();
- channelz_subchannel->RecordCallSucceeded();
- ValidateSubchannel(channelz_subchannel.get(), {3, 3, 3});
-}
-
INSTANTIATE_TEST_CASE_P(ChannelzChannelTestSweep, ChannelzChannelTest,
::testing::Values(0, 1, 2, 6, 10, 15));
-INSTANTIATE_TEST_CASE_P(ChannelzSubchannelTestSweep, ChannelzSubchannelTest,
- ::testing::Values(0, 1, 10, 15));
} // namespace testing
} // namespace channelz