diff options
-rw-r--r-- | templates/tools/dockerfile/test/sanity/Dockerfile.template | 3 | ||||
-rwxr-xr-x | tools/distrib/check_vsprojects.py | 84 | ||||
-rw-r--r-- | tools/dockerfile/test/sanity/Dockerfile | 3 | ||||
-rw-r--r-- | tools/run_tests/sanity/sanity_tests.yaml | 1 |
4 files changed, 89 insertions, 2 deletions
diff --git a/templates/tools/dockerfile/test/sanity/Dockerfile.template b/templates/tools/dockerfile/test/sanity/Dockerfile.template index 1baa9c896b..8d6f52db54 100644 --- a/templates/tools/dockerfile/test/sanity/Dockerfile.template +++ b/templates/tools/dockerfile/test/sanity/Dockerfile.template @@ -40,7 +40,8 @@ automake ${"\\"} libtool ${"\\"} curl ${"\\"} - python-virtualenv + python-virtualenv ${"\\"} + python-lxml RUN pip install simplejson mako #=================== diff --git a/tools/distrib/check_vsprojects.py b/tools/distrib/check_vsprojects.py new file mode 100755 index 0000000000..96dd2e4487 --- /dev/null +++ b/tools/distrib/check_vsprojects.py @@ -0,0 +1,84 @@ +#!/usr/bin/env python2.7 + +# Copyright 2016, Google Inc. +# All rights reserved. +# +# Redistribution and use in source and binary forms, with or without +# modification, are permitted provided that the following conditions are +# met: +# +# * Redistributions of source code must retain the above copyright +# notice, this list of conditions and the following disclaimer. +# * Redistributions in binary form must reproduce the above +# copyright notice, this list of conditions and the following disclaimer +# in the documentation and/or other materials provided with the +# distribution. +# * Neither the name of Google Inc. nor the names of its +# contributors may be used to endorse or promote products derived from +# this software without specific prior written permission. +# +# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS +# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT +# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR +# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT +# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, +# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT +# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, +# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY +# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT +# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE +# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + +import os +import re +import sys + +from lxml import etree + + +def main(): + root_dir = os.path.abspath( + os.path.join(os.path.dirname(sys.argv[0]), '../..')) + os.chdir(root_dir) + + project_re = re.compile('Project\(.*\) = ".+", "(.+)", "(.+)"') + + known_projects = {} + with open(os.path.join('vsprojects', 'grpc.sln')) as f: + for line in f.readlines(): + m = project_re.match(line) + if not m: + continue + + vcxproj_path, project_guid = m.groups() + if os.name != 'nt': + vcxproj_path = vcxproj_path.replace('\\', '/') + + known_projects[project_guid] = vcxproj_path + + ok = True + for vcxproj_path in known_projects.values(): + with open(os.path.join(root_dir, 'vsprojects', vcxproj_path)) as f: + tree = etree.parse(f) + + namespaces = {'ns': 'http://schemas.microsoft.com/developer/msbuild/2003'} + referenced_projects = tree.getroot().xpath('/ns:Project/ns:ItemGroup' + '/ns:ProjectReference' + '/ns:Project', + namespaces=namespaces) + for referenced_project in referenced_projects: + # Project tag under ProjectReference is a GUID reference. + if referenced_project.text not in known_projects: + target_vcxproj = referenced_project.getparent().attrib['Include'] + guid = referenced_project.text + print ('In project "%s", dependency "%s" (with GUID "%s") is not in ' + 'grpc.sln' % (vcxproj_path, target_vcxproj, guid)) + ok = False + + if not ok: + exit(1) + + +if __name__ == '__main__': + main() + diff --git a/tools/dockerfile/test/sanity/Dockerfile b/tools/dockerfile/test/sanity/Dockerfile index 57032155e3..3146a922b7 100644 --- a/tools/dockerfile/test/sanity/Dockerfile +++ b/tools/dockerfile/test/sanity/Dockerfile @@ -71,7 +71,8 @@ RUN apt-get update && apt-get install -y \ automake \ libtool \ curl \ - python-virtualenv + python-virtualenv \ + python-lxml RUN pip install simplejson mako #=================== diff --git a/tools/run_tests/sanity/sanity_tests.yaml b/tools/run_tests/sanity/sanity_tests.yaml index f155c8da45..efc21e6591 100644 --- a/tools/run_tests/sanity/sanity_tests.yaml +++ b/tools/run_tests/sanity/sanity_tests.yaml @@ -5,6 +5,7 @@ - script: tools/buildgen/generate_projects.sh -j 3 cpu_cost: 3 - script: tools/distrib/check_copyright.py +- script: tools/distrib/check_vsprojects.py - script: tools/distrib/clang_format_code.sh - script: tools/distrib/check_trailing_newlines.sh - script: tools/distrib/check_nanopb_output.sh |