diff options
| author |  Mehrdad Afshari <mmx@google.com> | 2017-12-18 16:35:02 -0800 |
|---|---|---|
| committer | Mehrdad Afshari <mmx@google.com> | 2017-12-19 08:59:28 -0800 |
| commit | a2ed77db5624f780e0e7625504e3233f45e6b08d (patch) | |
| tree | 37bba7cfb81646b54163c58f9705ca93673dc80b /tools | |
| parent | 795e8ebdc47a7829310d44b84c15fda9695a2873 (diff) | |
Add a sanity test for shellcheck
Start by checking the scripts in tools/run_tests/helper_scripts.
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/dockerfile/test/sanity/Dockerfile | 3 | ||||
| -rwxr-xr-x | tools/run_tests/sanity/check_shellcheck.sh | 27 | ||||
| -rw-r--r-- | tools/run_tests/sanity/sanity_tests.yaml | 1 |
3 files changed, 30 insertions, 1 deletions
diff --git a/tools/dockerfile/test/sanity/Dockerfile b/tools/dockerfile/test/sanity/Dockerfile index e4a2972c0e..6e5a133a69 100644 --- a/tools/dockerfile/test/sanity/Dockerfile +++ b/tools/dockerfile/test/sanity/Dockerfile @@ -81,7 +81,8 @@ RUN apt-get update && apt-get install -y \ libtool \ curl \ python-virtualenv \ - python-lxml + python-lxml \ + shellcheck RUN pip install simplejson mako #====================================== diff --git a/tools/run_tests/sanity/check_shellcheck.sh b/tools/run_tests/sanity/check_shellcheck.sh new file mode 100755 index 0000000000..f9b09167db --- /dev/null +++ b/tools/run_tests/sanity/check_shellcheck.sh @@ -0,0 +1,27 @@ +#!/usr/bin/env bash +# Copyright 2017 gRPC authors. +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + + +set -e + +ROOT="$(dirname "$0")/../../.." + +DIRS=( + 'tools/run_tests/helper_scripts' +) + +for dir in "${DIRS[@]}"; do + find "$ROOT/$dir/" -name "*.sh" -type f -print0 | xargs -n1 -0 shellcheck +done diff --git a/tools/run_tests/sanity/sanity_tests.yaml b/tools/run_tests/sanity/sanity_tests.yaml index 3ce864a8bd..dab991a7b1 100644 --- a/tools/run_tests/sanity/sanity_tests.yaml +++ b/tools/run_tests/sanity/sanity_tests.yaml @@ -3,6 +3,7 @@ - script: tools/run_tests/sanity/check_cache_mk.sh - script: tools/run_tests/sanity/check_owners.sh - script: tools/run_tests/sanity/check_sources_and_headers.py +- script: tools/run_tests/sanity/check_shellcheck.sh - script: tools/run_tests/sanity/check_submodules.sh - script: tools/run_tests/sanity/check_test_filtering.py - script: tools/run_tests/sanity/check_tracer_sanity.py |