aboutsummaryrefslogtreecommitdiffhomepage
path: root/tools
diff options
context:
space:
mode:
authorGravatar ncteisen <ncteisen@gmail.com>2018-01-17 07:55:07 -0800
committerGravatar ncteisen <ncteisen@gmail.com>2018-01-17 07:55:07 -0800
commit479067b2b5820709c3f5c8dcb073bf066ee648de (patch)
treeaef3b82177db9b9946840e396c798ed4230ff7ae /tools
parentc4aba517a50afa868de40891bbe696947d2d50d4 (diff)
do not fix automatically
Diffstat (limited to 'tools')
-rwxr-xr-xtools/distrib/clang_tidy_code.sh4
-rwxr-xr-xtools/dockerfile/grpc_clang_tidy/clang_tidy_all_the_things.sh2
2 files changed, 4 insertions, 2 deletions
diff --git a/tools/distrib/clang_tidy_code.sh b/tools/distrib/clang_tidy_code.sh
index 7f3dfb116f..5da86aa277 100755
--- a/tools/distrib/clang_tidy_code.sh
+++ b/tools/distrib/clang_tidy_code.sh
@@ -13,6 +13,8 @@
# See the License for the specific language governing permissions and
# limitations under the License.
+echo "NOTE: to automagically apply fixes, invoke with --fix"
+
set -ex
# change to root directory
@@ -27,5 +29,5 @@ then
# run clang-tidy against the checked out codebase
docker run -e TEST=$TEST -e CHANGED_FILES="$CHANGED_FILES" -e CLANG_TIDY_ROOT="/local-code" --rm=true -v "${REPO_ROOT}":/local-code -t grpc_clang_tidy /clang_tidy_all_the_things.sh "$@"
else
- CLANG_TIDY_ROOT="${REPO_ROOT}" tools/dockerfile/grpc_clang_tidy/clang_tidy_all_the_things.sh
+ CLANG_TIDY_ROOT="${REPO_ROOT}" tools/dockerfile/grpc_clang_tidy/clang_tidy_all_the_things.sh "$@"
fi
diff --git a/tools/dockerfile/grpc_clang_tidy/clang_tidy_all_the_things.sh b/tools/dockerfile/grpc_clang_tidy/clang_tidy_all_the_things.sh
index cb22d75489..1a82dd52b7 100755
--- a/tools/dockerfile/grpc_clang_tidy/clang_tidy_all_the_things.sh
+++ b/tools/dockerfile/grpc_clang_tidy/clang_tidy_all_the_things.sh
@@ -21,4 +21,4 @@ CLANG_TIDY=${CLANG_TIDY:-clang-tidy-5.0}
cd ${CLANG_TIDY_ROOT}
find src/core src/cpp test/core test/cpp -name '*.h' -or -name '*.cc' -print0 \
- | xargs -0 tools/distrib/run_clang_tidy.py --fix
+ | xargs -0 tools/distrib/run_clang_tidy.py "$@"