aboutsummaryrefslogtreecommitdiffhomepage
path: root/tools
diff options
context:
space:
mode:
authorGravatar Mark D. Roth <roth@google.com>2016-12-02 10:53:26 -0800
committerGravatar Mark D. Roth <roth@google.com>2016-12-02 10:53:26 -0800
commit158a4a42b2dfd1712b3ca81daf68162df04460c6 (patch)
treefb0c403b323da989ae765c2c4e86b5cb61f475af /tools
parent6288542146de017d0e07f733cb70dc9456b647c8 (diff)
Add comment about testing with reviewable.
Diffstat (limited to 'tools')
-rwxr-xr-xtools/run_tests/jobset.py4
1 files changed, 4 insertions, 0 deletions
diff --git a/tools/run_tests/jobset.py b/tools/run_tests/jobset.py
index 8c3b6ddda8..2acc7971f6 100755
--- a/tools/run_tests/jobset.py
+++ b/tools/run_tests/jobset.py
@@ -50,6 +50,10 @@ _DEFAULT_MAX_JOBS = 16 * multiprocessing.cpu_count()
_MAX_RESULT_SIZE = 8192
+# NOTE: If you change this, please make sure to test reviewing the
+# github PR with http://reviewable.io, which is known to add UTF-8
+# characters to the PR description, which leak into the environment here
+# and cause failures.
def strip_non_ascii_chars(s):
return ''.join(c for c in s if ord(c) < 128)