diff options
author | Matt Kwong <mattkwong@google.com> | 2017-05-19 15:22:19 -0700 |
---|---|---|
committer | Matt Kwong <mattkwong@google.com> | 2017-06-09 08:21:10 -0700 |
commit | 68309b42d50ee71b358130793ede96b4725d02b0 (patch) | |
tree | 5f43832221031a0665f3008362ea5bcf79c9f800 /tools/run_tests | |
parent | 18528f28f3600123e356e9367e462fab96081d77 (diff) |
Add test to check if bazel subdirectory was modified
Diffstat (limited to 'tools/run_tests')
-rwxr-xr-x | tools/run_tests/python_utils/check_bazel_dir.py | 41 |
1 files changed, 41 insertions, 0 deletions
diff --git a/tools/run_tests/python_utils/check_bazel_dir.py b/tools/run_tests/python_utils/check_bazel_dir.py new file mode 100755 index 0000000000..1daf6ee595 --- /dev/null +++ b/tools/run_tests/python_utils/check_bazel_dir.py @@ -0,0 +1,41 @@ +#!/usr/bin/env python +# Copyright 2017 gRPC authors. +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +"""This sends out a warning if any changes to the bazel dir are made.""" + +from __future__ import print_function +from subprocess import check_output + +import comment_on_pr +import os + +_WARNING_MESSAGE = 'WARNING: You are making changes in the Bazel subdirectory. ' \ + 'Please get explicit approval from @nicolasnoble before merging.' + + +def _get_changed_files(base_branch): + """ + Get list of changed files between current branch and base of target merge branch + """ + # Get file changes between branch and merge-base of specified branch + base_commit = check_output(["git", "merge-base", base_branch, "HEAD"]).rstrip() + return check_output(["git", "diff", base_commit, "--name-only"]).splitlines() + + +# ghprbTargetBranch environment variable only available during a Jenkins PR tests +if 'ghprbTargetBranch' in os.environ: + changed_files = _get_changed_files('origin/%s' % os.environ['ghprbTargetBranch']) + if any(file.startswith('bazel/') for file in changed_files): + comment_on_pr.comment_on_pr(_WARNING_MESSAGE) |