diff options
| author |  Vijay Pai <vpai@google.com> | 2018-08-16 15:55:53 -0700 |
|---|---|---|
| committer | Vijay Pai <vpai@google.com> | 2018-08-16 15:55:53 -0700 |
| commit | 79851428e9d46b7e830d60e5150f9dd788a6332f (patch) | |
| tree | 215b815f987418f7a80316815763c5defc5bfa50 /tools/run_tests/sanity | |
| parent | 381bcab8bde911a0aa03d2148f2b291c1c846481 (diff) | |
Add a sanity check to avoid reintroducing dependence on cpp by core
Diffstat (limited to 'tools/run_tests/sanity')
| -rwxr-xr-x | tools/run_tests/sanity/check_bad_dependencies.sh (renamed from tools/run_tests/sanity/check_unsecure.sh) | 4 | ||||
| -rw-r--r-- | tools/run_tests/sanity/sanity_tests.yaml | 2 |
2 files changed, 5 insertions, 1 deletions
diff --git a/tools/run_tests/sanity/check_unsecure.sh b/tools/run_tests/sanity/check_bad_dependencies.sh index cca1235479..5ae0e02c81 100755 --- a/tools/run_tests/sanity/check_unsecure.sh +++ b/tools/run_tests/sanity/check_bad_dependencies.sh @@ -23,5 +23,9 @@ test "$(bazel query 'somepath("//:grpc++_unsecure", "//external:libssl")' 2>/dev test "$(bazel query 'somepath("//:grpc++_codegen_proto", "//external:libssl")' 2>/dev/null | wc -l)" -eq 0 || exit 1 test "$(bazel query 'somepath("//test/cpp/microbenchmarks:helpers", "//external:libssl")' 2>/dev/null | wc -l)" -eq 0 || exit 1 +# Make sure that core doesn't depend on anything in C++ library + +test "$(bazel query 'deps("//:grpc")' 2>/dev/null | egrep 'src/cpp|include/grpcpp' | wc -l)" -eq 0 || exit 1 + exit 0 diff --git a/tools/run_tests/sanity/sanity_tests.yaml b/tools/run_tests/sanity/sanity_tests.yaml index ac0d4c70e5..91b53eb38d 100644 --- a/tools/run_tests/sanity/sanity_tests.yaml +++ b/tools/run_tests/sanity/sanity_tests.yaml @@ -1,4 +1,5 @@ # a set of tests that are run in parallel for sanity tests +- script: tools/run_tests/sanity/check_bad_dependencies.sh - script: tools/run_tests/sanity/check_bazel_workspace.py - script: tools/run_tests/sanity/check_cache_mk.sh - script: tools/run_tests/sanity/check_owners.sh @@ -6,7 +7,6 @@ - script: tools/run_tests/sanity/check_submodules.sh - script: tools/run_tests/sanity/check_test_filtering.py - script: tools/run_tests/sanity/check_tracer_sanity.py -- script: tools/run_tests/sanity/check_unsecure.sh - script: tools/run_tests/sanity/core_banned_functions.py - script: tools/run_tests/sanity/core_untyped_structs.sh - script: tools/run_tests/sanity/check_deprecated_grpc++.py |