diff options
author | 2017-12-11 16:56:44 -0800 | |
---|---|---|
committer | 2017-12-11 16:56:44 -0800 | |
commit | 0cd6cfefa0a21ccf8dc28d623c03f3425e9ed72b (patch) | |
tree | 2e87bc7e8db658692b79177d1e3d7c09f2c63773 /tools/run_tests/sanity/check_version.py | |
parent | 05687c3da9848ab79f08417793965de9bbbb52b0 (diff) |
yapf tools/run_tests/sanity
Diffstat (limited to 'tools/run_tests/sanity/check_version.py')
-rwxr-xr-x | tools/run_tests/sanity/check_version.py | 76 |
1 files changed, 38 insertions, 38 deletions
diff --git a/tools/run_tests/sanity/check_version.py b/tools/run_tests/sanity/check_version.py index b9b6bab26d..6154b2603e 100755 --- a/tools/run_tests/sanity/check_version.py +++ b/tools/run_tests/sanity/check_version.py @@ -31,56 +31,56 @@ sys.path.insert(0, os.path.abspath('tools/buildgen/plugins')) from expand_version import Version try: - branch_name = subprocess.check_output( - 'git rev-parse --abbrev-ref HEAD', - shell=True) + branch_name = subprocess.check_output( + 'git rev-parse --abbrev-ref HEAD', shell=True) except: - print('WARNING: not a git repository') - branch_name = None + print('WARNING: not a git repository') + branch_name = None if branch_name is not None: - m = re.match(r'^release-([0-9]+)_([0-9]+)$', branch_name) - if m: - print('RELEASE branch') - # version number should align with the branched version - check_version = lambda version: ( - version.major == int(m.group(1)) and - version.minor == int(m.group(2))) - warning = 'Version key "%%s" value "%%s" should have a major version %s and minor version %s' % (m.group(1), m.group(2)) - elif re.match(r'^debian/.*$', branch_name): - # no additional version checks for debian branches - check_version = lambda version: True - else: - # all other branches should have a -dev tag - check_version = lambda version: version.tag == 'dev' - warning = 'Version key "%s" value "%s" should have a -dev tag' + m = re.match(r'^release-([0-9]+)_([0-9]+)$', branch_name) + if m: + print('RELEASE branch') + # version number should align with the branched version + check_version = lambda version: ( + version.major == int(m.group(1)) and + version.minor == int(m.group(2))) + warning = 'Version key "%%s" value "%%s" should have a major version %s and minor version %s' % ( + m.group(1), m.group(2)) + elif re.match(r'^debian/.*$', branch_name): + # no additional version checks for debian branches + check_version = lambda version: True + else: + # all other branches should have a -dev tag + check_version = lambda version: version.tag == 'dev' + warning = 'Version key "%s" value "%s" should have a -dev tag' else: - check_version = lambda version: True + check_version = lambda version: True with open('build.yaml', 'r') as f: - build_yaml = yaml.load(f.read()) + build_yaml = yaml.load(f.read()) settings = build_yaml['settings'] top_version = Version(settings['version']) if not check_version(top_version): - errors += 1 - print(warning % ('version', top_version)) + errors += 1 + print(warning % ('version', top_version)) for tag, value in settings.iteritems(): - if re.match(r'^[a-z]+_version$', tag): - value = Version(value) - if tag != 'core_version': - if value.major != top_version.major: - errors += 1 - print('major version mismatch on %s: %d vs %d' % (tag, value.major, - top_version.major)) - if value.minor != top_version.minor: - errors += 1 - print('minor version mismatch on %s: %d vs %d' % (tag, value.minor, - top_version.minor)) - if not check_version(value): - errors += 1 - print(warning % (tag, value)) + if re.match(r'^[a-z]+_version$', tag): + value = Version(value) + if tag != 'core_version': + if value.major != top_version.major: + errors += 1 + print('major version mismatch on %s: %d vs %d' % + (tag, value.major, top_version.major)) + if value.minor != top_version.minor: + errors += 1 + print('minor version mismatch on %s: %d vs %d' % + (tag, value.minor, top_version.minor)) + if not check_version(value): + errors += 1 + print(warning % (tag, value)) sys.exit(errors) |