aboutsummaryrefslogtreecommitdiffhomepage
path: root/tools/run_tests/run_interop_tests.py
diff options
context:
space:
mode:
authorGravatar Jan Tattermusch <jtattermusch@google.com>2016-11-17 15:28:57 +0100
committerGravatar Jan Tattermusch <jtattermusch@google.com>2016-11-18 11:06:53 +0100
commit03b7612a22c6868f0e1f9320409a5918895455cc (patch)
tree00f3e14cf4be7aed861d31da0c2c443be3bd0d53 /tools/run_tests/run_interop_tests.py
parent34e8b91726c0cc661e8e717e9da140577c3ad885 (diff)
stop using login shell for invoking interop tests
Diffstat (limited to 'tools/run_tests/run_interop_tests.py')
-rwxr-xr-xtools/run_tests/run_interop_tests.py13
1 files changed, 6 insertions, 7 deletions
diff --git a/tools/run_tests/run_interop_tests.py b/tools/run_tests/run_interop_tests.py
index f3255e3a56..6a01bc23c4 100755
--- a/tools/run_tests/run_interop_tests.py
+++ b/tools/run_tests/run_interop_tests.py
@@ -452,12 +452,11 @@ def docker_run_cmdline(cmdline, image, docker_args=[], cwd=None, environ=None):
return docker_cmdline
-def bash_login_cmdline(cmdline):
- """Creates bash -l -c cmdline from args list."""
+def bash_cmdline(cmdline):
+ """Creates bash -c cmdline from args list."""
# Use login shell:
- # * rvm and nvm require it
# * makes error messages clearer if executables are missing
- return ['bash', '-l', '-c', ' '.join(cmdline)]
+ return ['bash', '-c', ' '.join(cmdline)]
def auth_options(language, test_case):
@@ -517,7 +516,7 @@ def cloud_to_prod_jobspec(language, test_case, server_host_name,
auth_cmdargs, auth_env = auth_options(language, test_case)
cmdargs += auth_cmdargs
environ.update(auth_env)
- cmdline = bash_login_cmdline(language.client_cmd(cmdargs))
+ cmdline = bash_cmdline(language.client_cmd(cmdargs))
cwd = language.client_cwd
if docker_image:
@@ -551,7 +550,7 @@ def cloud_to_prod_jobspec(language, test_case, server_host_name,
def cloud_to_cloud_jobspec(language, test_case, server_name, server_host,
server_port, docker_image=None):
"""Creates jobspec for cloud-to-cloud interop test"""
- cmdline = bash_login_cmdline(language.client_cmd([
+ cmdline = bash_cmdline(language.client_cmd([
'--server_host_override=foo.test.google.fr',
'--use_tls=true',
'--use_test_ca=true',
@@ -588,7 +587,7 @@ def cloud_to_cloud_jobspec(language, test_case, server_name, server_host,
def server_jobspec(language, docker_image):
"""Create jobspec for running a server"""
container_name = dockerjob.random_name('interop_server_%s' % language.safename)
- cmdline = bash_login_cmdline(
+ cmdline = bash_cmdline(
language.server_cmd(['--port=%s' % _DEFAULT_SERVER_PORT]))
environ = language.global_env()
docker_cmdline = docker_run_cmdline(cmdline,