diff options
| author |  Mehrdad Afshari <mmx@google.com> | 2018-01-26 11:01:22 -0800 |
|---|---|---|
| committer | Mehrdad Afshari <mmx@google.com> | 2018-01-26 12:16:28 -0800 |
| commit | 52391111e34816ee13bf4be73f8815dbb2a74407 (patch) | |
| tree | ba4055db3ce1a07a3f01f6e2f18b1ee5a08bbe41 /tools/run_tests/performance | |
| parent | 9e0cecc6e4c43a04d9b93483a7c5a24d6acca666 (diff) | |
Fix process_remote_perf_flamegraphs.sh to pass shellcheck
Diffstat (limited to 'tools/run_tests/performance')
| -rwxr-xr-x | tools/run_tests/performance/process_remote_perf_flamegraphs.sh | 15 |
1 files changed, 8 insertions, 7 deletions
diff --git a/tools/run_tests/performance/process_remote_perf_flamegraphs.sh b/tools/run_tests/performance/process_remote_perf_flamegraphs.sh index a0c4f6ff32..2ea6b4f2a6 100755 --- a/tools/run_tests/performance/process_remote_perf_flamegraphs.sh +++ b/tools/run_tests/performance/process_remote_perf_flamegraphs.sh @@ -13,17 +13,18 @@ # See the License for the specific language governing permissions and # limitations under the License. -mkdir -p $OUTPUT_DIR +mkdir -p "$OUTPUT_DIR" -PERF_DATA_FILE=${PERF_BASE_NAME}-perf.data -PERF_SCRIPT_OUTPUT=${PERF_BASE_NAME}-out.perf +PERF_DATA_FILE="${PERF_BASE_NAME}-perf.data" +PERF_SCRIPT_OUTPUT="${PERF_BASE_NAME}-out.perf" # Generate Flame graphs echo "running perf script on $USER_AT_HOST with perf.data" -ssh $USER_AT_HOST "cd ~/performance_workspace/grpc && perf script -i $PERF_DATA_FILE | gzip > ${PERF_SCRIPT_OUTPUT}.gz" +# shellcheck disable=SC2029 +ssh "$USER_AT_HOST" "cd ~/performance_workspace/grpc && perf script -i $PERF_DATA_FILE | gzip > ${PERF_SCRIPT_OUTPUT}.gz" -scp $USER_AT_HOST:~/performance_workspace/grpc/$PERF_SCRIPT_OUTPUT.gz . +scp "$USER_AT_HOST:~/performance_workspace/grpc/$PERF_SCRIPT_OUTPUT.gz" . -gzip -d -f $PERF_SCRIPT_OUTPUT.gz +gzip -d -f "$PERF_SCRIPT_OUTPUT.gz" -~/FlameGraph/stackcollapse-perf.pl --kernel $PERF_SCRIPT_OUTPUT | ~/FlameGraph/flamegraph.pl --color=java --hash > ${OUTPUT_DIR}/${OUTPUT_FILENAME}.svg +~/FlameGraph/stackcollapse-perf.pl --kernel "$PERF_SCRIPT_OUTPUT" | ~/FlameGraph/flamegraph.pl --color=java --hash > "${OUTPUT_DIR}/${OUTPUT_FILENAME}.svg" |