aboutsummaryrefslogtreecommitdiffhomepage
path: root/tools/distrib
diff options
context:
space:
mode:
authorGravatar ncteisen <ncteisen@gmail.com>2018-01-12 15:26:30 -0800
committerGravatar Noah Eisen <ncteisen@google.com>2018-01-16 17:24:51 -0800
commit1adad729797df4cb8c92c26fcdb5f59a72261fd4 (patch)
treef07454e523247af166b013649d65620dbadd7b92 /tools/distrib
parent365ea6309bd683d384b58e05fdb58e557b20ba19 (diff)
Add to sanity, dont fix by default
Diffstat (limited to 'tools/distrib')
-rwxr-xr-xtools/distrib/clang_tidy_code.sh2
-rwxr-xr-xtools/distrib/run_clang_tidy.py3
2 files changed, 2 insertions, 3 deletions
diff --git a/tools/distrib/clang_tidy_code.sh b/tools/distrib/clang_tidy_code.sh
index c5bfc5ca4c..b9d4368997 100755
--- a/tools/distrib/clang_tidy_code.sh
+++ b/tools/distrib/clang_tidy_code.sh
@@ -25,7 +25,7 @@ then
docker build -t grpc_clang_tidy tools/dockerfile/grpc_clang_tidy
# run clang-tidy against the checked out codebase
- docker run -e TEST=$TEST -e CHANGED_FILES="$CHANGED_FILES" -e CLANG_TIDY_ROOT="/local-code" --rm=true -v "${REPO_ROOT}":/local-code -t grpc_clang_tidy /clang_tidy_all_the_things.sh
+ docker run -e TEST=$TEST -e CHANGED_FILES="$CHANGED_FILES" -e CLANG_TIDY_ROOT="/local-code" --rm=true -v "${REPO_ROOT}":/local-code -t grpc_clang_tidy /clang_tidy_all_the_things.sh "$@"
else
CLANG_tidy_ROOT="${REPO_ROOT}" tools/dockerfile/grpc_clang_tidy/clang_tidy_all_the_things.sh
fi
diff --git a/tools/distrib/run_clang_tidy.py b/tools/distrib/run_clang_tidy.py
index 182897e491..bc61d4e79a 100755
--- a/tools/distrib/run_clang_tidy.py
+++ b/tools/distrib/run_clang_tidy.py
@@ -57,8 +57,7 @@ cmdline = [
clang_tidy,
'--checks=-*,%s' % ','.join(GRPC_CHECKS),
'--warnings-as-errors=%s' % ','.join(GRPC_CHECKS)
-]
-# + ['--extra-arg-before=%s' % arg for arg in extra_args]
+] + ['--extra-arg-before=%s' % arg for arg in extra_args]
if args.fix:
cmdline.append('--fix')