aboutsummaryrefslogtreecommitdiffhomepage
path: root/test
diff options
context:
space:
mode:
authorGravatar ncteisen <ncteisen@gmail.com>2017-11-17 13:39:01 -0800
committerGravatar ncteisen <ncteisen@gmail.com>2017-11-17 13:39:01 -0800
commitc4dd9cfe1893081b6783213f96d2b72b7b02d165 (patch)
treeac9180be073277cf77e5df91f08b048e321beb31 /test
parentb2aa06ae990e82b5c7f573f282b7bcfef7093d54 (diff)
reviewer feedback
Diffstat (limited to 'test')
-rw-r--r--test/core/iomgr/timer_list_test.cc8
-rw-r--r--test/core/transport/connectivity_state_test.cc3
-rw-r--r--test/core/util/tracer_peer.cc2
-rw-r--r--test/core/util/tracer_peer.h2
4 files changed, 7 insertions, 8 deletions
diff --git a/test/core/iomgr/timer_list_test.cc b/test/core/iomgr/timer_list_test.cc
index 73be93511b..5730a306ec 100644
--- a/test/core/iomgr/timer_list_test.cc
+++ b/test/core/iomgr/timer_list_test.cc
@@ -49,8 +49,8 @@ static void add_test(void) {
gpr_log(GPR_INFO, "add_test");
grpc_timer_list_init(&exec_ctx);
- grpc_core::testing::grpc_tracer_peer_enable_flag(&grpc_timer_trace);
- grpc_core::testing::grpc_tracer_peer_enable_flag(&grpc_timer_check_trace);
+ grpc_core::testing::grpc_tracer_enable_flag(&grpc_timer_trace);
+ grpc_core::testing::grpc_tracer_enable_flag(&grpc_timer_check_trace);
memset(cb_called, 0, sizeof(cb_called));
grpc_millis start = grpc_exec_ctx_now(&exec_ctx);
@@ -118,8 +118,8 @@ void destruction_test(void) {
exec_ctx.now_is_valid = true;
exec_ctx.now = 0;
grpc_timer_list_init(&exec_ctx);
- grpc_core::testing::grpc_tracer_peer_enable_flag(&grpc_timer_trace);
- grpc_core::testing::grpc_tracer_peer_enable_flag(&grpc_timer_check_trace);
+ grpc_core::testing::grpc_tracer_enable_flag(&grpc_timer_trace);
+ grpc_core::testing::grpc_tracer_enable_flag(&grpc_timer_check_trace);
memset(cb_called, 0, sizeof(cb_called));
grpc_timer_init(
diff --git a/test/core/transport/connectivity_state_test.cc b/test/core/transport/connectivity_state_test.cc
index e4d27950ec..f33bfd2c94 100644
--- a/test/core/transport/connectivity_state_test.cc
+++ b/test/core/transport/connectivity_state_test.cc
@@ -137,8 +137,7 @@ static void test_subscribe_with_failure_then_destroy(void) {
int main(int argc, char** argv) {
grpc_test_init(argc, argv);
- grpc_core::testing::grpc_tracer_peer_enable_flag(
- &grpc_connectivity_state_trace);
+ grpc_core::testing::grpc_tracer_enable_flag(&grpc_connectivity_state_trace);
test_connectivity_state_name();
test_check();
test_subscribe_then_unsubscribe();
diff --git a/test/core/util/tracer_peer.cc b/test/core/util/tracer_peer.cc
index acb770515f..34a132daa7 100644
--- a/test/core/util/tracer_peer.cc
+++ b/test/core/util/tracer_peer.cc
@@ -23,7 +23,7 @@
namespace grpc_core {
namespace testing {
-void grpc_tracer_peer_enable_flag(grpc_core::TraceFlag* flag) {
+void grpc_tracer_enable_flag(grpc_core::TraceFlag* flag) {
flag->set_enabled(1);
}
diff --git a/test/core/util/tracer_peer.h b/test/core/util/tracer_peer.h
index 0b6c6dd685..6dd04f6549 100644
--- a/test/core/util/tracer_peer.h
+++ b/test/core/util/tracer_peer.h
@@ -24,7 +24,7 @@ class TraceFlag;
namespace testing {
// enables the TraceFlag passed to it. Used for testing purposes.
-void grpc_tracer_peer_enable_flag(grpc_core::TraceFlag* flag);
+void grpc_tracer_enable_flag(grpc_core::TraceFlag* flag);
} // namespace testing
} // namespace grpc_core