diff options
author | ncteisen <ncteisen@gmail.com> | 2018-09-07 15:44:59 -0700 |
---|---|---|
committer | ncteisen <ncteisen@gmail.com> | 2018-09-07 15:44:59 -0700 |
commit | be8844bcdb704cff6a70507f5093e4bb26320ea3 (patch) | |
tree | bb58d1f011563a2f5838218837a039d18f6c6ae0 /test | |
parent | 4b5b019d5644affef122e06c6898811286850b8d (diff) |
reviewer feedback
Diffstat (limited to 'test')
-rw-r--r-- | test/core/channel/channel_trace_test.cc | 4 | ||||
-rw-r--r-- | test/core/channel/channelz_test.cc | 4 |
2 files changed, 4 insertions, 4 deletions
diff --git a/test/core/channel/channel_trace_test.cc b/test/core/channel/channel_trace_test.cc index e33277753b..d594445bfb 100644 --- a/test/core/channel/channel_trace_test.cc +++ b/test/core/channel/channel_trace_test.cc @@ -44,8 +44,8 @@ namespace testing { // testing peer to access channel internals class ChannelNodePeer { public: - ChannelNodePeer(ChannelNode* node) : node_(node) {} - ChannelTrace* trace() { return &node_->trace_; } + explicit ChannelNodePeer(ChannelNode* node) : node_(node) {} + ChannelTrace* trace() const { return &node_->trace_; } private: ChannelNode* node_; diff --git a/test/core/channel/channelz_test.cc b/test/core/channel/channelz_test.cc index 8fa46a18da..09189fa36d 100644 --- a/test/core/channel/channelz_test.cc +++ b/test/core/channel/channelz_test.cc @@ -46,8 +46,8 @@ namespace testing { // testing peer to access channel internals class CallCountingHelperPeer { public: - CallCountingHelperPeer(CallCountingHelper* node) : node_(node) {} - grpc_millis last_call_started_millis() { + explicit CallCountingHelperPeer(CallCountingHelper* node) : node_(node) {} + grpc_millis last_call_started_millis() const { return (grpc_millis)gpr_atm_no_barrier_load( &node_->last_call_started_millis_); } |