Support named scope id's with ipv6 resolver on posix

4 files changed, 235 insertions, 2 deletions

diff --git a/test/core/client_channel/BUILD b/test/core/client_channel/BUILD
index 04485f5240..57e5191af4 100644
--- a/test/core/client_channel/BUILD
+++ b/test/core/client_channel/BUILD
@@ -44,6 +44,17 @@ grpc_cc_test(
 )
 
 grpc_cc_test(
+    name = "parse_address_with_named_scope_id_test",
+    srcs = ["parse_address_with_named_scope_id_test.cc"],
+    language = "C++",
+    deps = [
+        "//:gpr",
+        "//:grpc",
+        "//test/core/util:grpc_test_util",
+    ],
+)
+
+grpc_cc_test(
     name = "uri_parser_test",
     srcs = ["uri_parser_test.cc"],
     language = "C++",
diff --git a/test/core/client_channel/parse_address_with_named_scope_id_test.cc b/test/core/client_channel/parse_address_with_named_scope_id_test.cc
new file mode 100644
index 0000000000..bfafa74517
--- /dev/null
+++ b/test/core/client_channel/parse_address_with_named_scope_id_test.cc
@@ -0,0 +1,126 @@
+/*
+ *
+ * Copyright 2017 gRPC authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+#include "src/core/ext/filters/client_channel/parse_address.h"
+#include "src/core/lib/iomgr/sockaddr.h"
+#include "src/core/lib/iomgr/socket_utils.h"
+
+#include <net/if.h>
+#include <string.h>
+#ifdef GRPC_HAVE_UNIX_SOCKET
+#include <sys/un.h>
+#endif
+
+#include <grpc/grpc.h>
+#include <grpc/support/log.h>
+#include <grpc/support/string_util.h>
+
+#include "src/core/lib/gpr/host_port.h"
+#include "src/core/lib/iomgr/exec_ctx.h"
+#include "src/core/lib/iomgr/socket_utils.h"
+#include "test/core/util/test_config.h"
+
+static void test_grpc_parse_ipv6_parity_with_getaddrinfo(
+    const char* target, const struct sockaddr_in6 result_from_getaddrinfo) {
+  // Get the sockaddr that gRPC's ipv6 resolver resolves this too.
+  grpc_core::ExecCtx exec_ctx;
+  grpc_uri* uri = grpc_uri_parse(target, 0);
+  grpc_resolved_address addr;
+  GPR_ASSERT(1 == grpc_parse_ipv6(uri, &addr));
+  grpc_sockaddr_in6* result_from_grpc_parser =
+      reinterpret_cast<grpc_sockaddr_in6*>(addr.addr);
+  // Compare the sockaddr returned from gRPC's ipv6 resolver with that returned
+  // from getaddrinfo.
+  GPR_ASSERT(result_from_grpc_parser->sin6_family == AF_INET6);
+  GPR_ASSERT(result_from_getaddrinfo.sin6_family == AF_INET6);
+  GPR_ASSERT(memcmp(&result_from_grpc_parser->sin6_addr,
+                    &result_from_getaddrinfo.sin6_addr, sizeof(in6_addr)) == 0);
+  GPR_ASSERT(result_from_grpc_parser->sin6_scope_id ==
+             result_from_getaddrinfo.sin6_scope_id);
+  GPR_ASSERT(result_from_grpc_parser->sin6_scope_id != 0);
+  // TODO: compare sin6_flow_info fields? parse_ipv6 zero's this field as is.
+  // Cleanup
+  grpc_uri_destroy(uri);
+}
+
+struct sockaddr_in6 resolve_with_gettaddrinfo(const char* uri_text) {
+  grpc_uri* uri = grpc_uri_parse(uri_text, 0);
+  char* host = nullptr;
+  char* port = nullptr;
+  gpr_split_host_port(uri->path, &host, &port);
+  struct addrinfo hints;
+  memset(&hints, 0, sizeof(hints));
+  hints.ai_family = AF_INET6;
+  hints.ai_socktype = SOCK_STREAM;
+  hints.ai_flags = AI_NUMERICHOST;
+  struct addrinfo* result;
+  int res = getaddrinfo(host, port, &hints, &result);
+  if (res != 0) {
+    gpr_log(GPR_ERROR,
+            "getaddrinfo failed to resolve host:%s port:%s. Error: %d.", host,
+            port, res);
+    abort();
+  }
+  size_t num_addrs_from_getaddrinfo = 0;
+  for (struct addrinfo* resp = result; resp != nullptr; resp = resp->ai_next) {
+    num_addrs_from_getaddrinfo++;
+  }
+  GPR_ASSERT(num_addrs_from_getaddrinfo == 1);
+  GPR_ASSERT(result->ai_family == AF_INET6);
+  struct sockaddr_in6 out =
+      *reinterpret_cast<struct sockaddr_in6*>(result->ai_addr);
+  // Cleanup
+  freeaddrinfo(result);
+  gpr_free(host);
+  gpr_free(port);
+  grpc_uri_destroy(uri);
+  return out;
+}
+
+int main(int argc, char** argv) {
+  grpc_test_init(argc, argv);
+  grpc_init();
+  char* arbitrary_interface_name = static_cast<char*>(gpr_zalloc(IF_NAMESIZE));
+  // Per RFC 3493, an interface index is a "small positive integer starts at 1".
+  // Probe candidate interface index numbers until we find one that the
+  // system recognizes, and then use that for the test.
+  for (size_t i = 1; i < 65536; i++) {
+    if (if_indextoname(i, arbitrary_interface_name) != nullptr) {
+      gpr_log(
+          GPR_DEBUG,
+          "Found interface at index %d named %s. Will use this for the test",
+          (int)i, arbitrary_interface_name);
+      break;
+    }
+  }
+  GPR_ASSERT(strlen(arbitrary_interface_name) > 0);
+  char* target = nullptr;
+  gpr_asprintf(&target, "ipv6:[fe80::1234%%%s]:12345",
+               arbitrary_interface_name);
+  struct sockaddr_in6 result_from_getaddrinfo =
+      resolve_with_gettaddrinfo(target);
+  // Run the test
+  gpr_log(GPR_DEBUG,
+          "Run test_grpc_parse_ipv6_parity_with_getaddrinfo with target: %s",
+          target);
+  test_grpc_parse_ipv6_parity_with_getaddrinfo(target, result_from_getaddrinfo);
+  // Cleanup
+  gpr_free(target);
+  gpr_free(arbitrary_interface_name);
+  grpc_shutdown();
+}
diff --git a/test/core/iomgr/BUILD b/test/core/iomgr/BUILD
index e920ceacf0..5acf269988 100644
--- a/test/core/iomgr/BUILD
+++ b/test/core/iomgr/BUILD
@@ -128,8 +128,25 @@ grpc_cc_test(
 )
 
 grpc_cc_test(
-    name = "resolve_address_posix_test",
+    name = "resolve_address_using_ares_resolver_posix_test",
     srcs = ["resolve_address_posix_test.cc"],
+    args = [
+        "--resolver=ares",
+    ],
+    language = "C++",
+    deps = [
+        "//:gpr",
+        "//:grpc",
+        "//test/core/util:grpc_test_util",
+    ],
+)
+
+grpc_cc_test(
+    name = "resolve_address_using_native_resolver_posix_test",
+    srcs = ["resolve_address_posix_test.cc"],
+    args = [
+        "--resolver=native",
+    ],
     language = "C++",
     deps = [
         "//:gpr",
diff --git a/test/core/iomgr/resolve_address_posix_test.cc b/test/core/iomgr/resolve_address_posix_test.cc
index 5785c73e22..826c7e1faf 100644
--- a/test/core/iomgr/resolve_address_posix_test.cc
+++ b/test/core/iomgr/resolve_address_posix_test.cc
@@ -18,12 +18,14 @@
 
 #include "src/core/lib/iomgr/resolve_address.h"
 
+#include <net/if.h>
 #include <string.h>
 #include <sys/un.h>
 
 #include <grpc/grpc.h>
 #include <grpc/support/alloc.h>
 #include <grpc/support/log.h>
+#include <grpc/support/string_util.h>
 #include <grpc/support/sync.h>
 #include <grpc/support/time.h>
 
@@ -33,6 +35,7 @@
 #include "src/core/lib/gprpp/thd.h"
 #include "src/core/lib/iomgr/executor.h"
 #include "src/core/lib/iomgr/iomgr.h"
+#include "test/core/util/cmdline.h"
 #include "test/core/util/test_config.h"
 
 static gpr_timespec test_deadline(void) {
@@ -117,12 +120,18 @@ static void must_succeed(void* argsp, grpc_error* err) {
   GPR_ASSERT(args->addrs != nullptr);
   GPR_ASSERT(args->addrs->naddrs > 0);
   gpr_atm_rel_store(&args->done_atm, 1);
+  gpr_mu_lock(args->mu);
+  GRPC_LOG_IF_ERROR("pollset_kick", grpc_pollset_kick(args->pollset, nullptr));
+  gpr_mu_unlock(args->mu);
 }
 
 static void must_fail(void* argsp, grpc_error* err) {
   args_struct* args = static_cast<args_struct*>(argsp);
   GPR_ASSERT(err != GRPC_ERROR_NONE);
   gpr_atm_rel_store(&args->done_atm, 1);
+  gpr_mu_lock(args->mu);
+  GRPC_LOG_IF_ERROR("pollset_kick", grpc_pollset_kick(args->pollset, nullptr));
+  gpr_mu_unlock(args->mu);
 }
 
 static void test_unix_socket(void) {
@@ -159,22 +168,92 @@ static void test_unix_socket_path_name_too_long(void) {
   args_finish(&args);
 }
 
+static void resolve_address_must_succeed(const char* target) {
+  grpc_core::ExecCtx exec_ctx;
+  args_struct args;
+  args_init(&args);
+  poll_pollset_until_request_done(&args);
+  grpc_resolve_address(
+      target, "1" /* port number */, args.pollset_set,
+      GRPC_CLOSURE_CREATE(must_succeed, &args, grpc_schedule_on_exec_ctx),
+      &args.addrs);
+  grpc_core::ExecCtx::Get()->Flush();
+  args_finish(&args);
+}
+
+static void test_named_and_numeric_scope_ids(void) {
+  char* arbitrary_interface_name = static_cast<char*>(gpr_zalloc(IF_NAMESIZE));
+  int interface_index = 0;
+  // Probe candidate interface index numbers until we find one that the
+  // system recognizes, and then use that for the test.
+  for (size_t i = 1; i < 65536; i++) {
+    if (if_indextoname(i, arbitrary_interface_name) != nullptr) {
+      gpr_log(
+          GPR_DEBUG,
+          "Found interface at index %d named %s. Will use this for the test",
+          (int)i, arbitrary_interface_name);
+      interface_index = (int)i;
+      break;
+    }
+  }
+  GPR_ASSERT(strlen(arbitrary_interface_name) > 0);
+  // Test resolution of an ipv6 address with a named scope ID
+  gpr_log(GPR_DEBUG, "test resolution with a named scope ID");
+  char* target_with_named_scope_id = nullptr;
+  gpr_asprintf(&target_with_named_scope_id, "fe80::1234%%%s",
+               arbitrary_interface_name);
+  resolve_address_must_succeed(target_with_named_scope_id);
+  gpr_free(target_with_named_scope_id);
+  gpr_free(arbitrary_interface_name);
+  // Test resolution of an ipv6 address with a numeric scope ID
+  gpr_log(GPR_DEBUG, "test resolution with a numeric scope ID");
+  char* target_with_numeric_scope_id = nullptr;
+  gpr_asprintf(&target_with_numeric_scope_id, "fe80::1234%%%d",
+               interface_index);
+  resolve_address_must_succeed(target_with_numeric_scope_id);
+  gpr_free(target_with_numeric_scope_id);
+}
+
 int main(int argc, char** argv) {
+  // First set the resolver type based off of --resolver
+  const char* resolver_type = nullptr;
+  gpr_cmdline* cl = gpr_cmdline_create("resolve address test");
+  gpr_cmdline_add_string(cl, "resolver", "Resolver type (ares or native)",
+                         &resolver_type);
+  // In case that there are more than one argument on the command line,
+  // --resolver will always be the first one, so only parse the first argument
+  // (other arguments may be unknown to cl)
+  gpr_cmdline_parse(cl, argc > 2 ? 2 : argc, argv);
+  const char* cur_resolver = gpr_getenv("GRPC_DNS_RESOLVER");
+  if (cur_resolver != nullptr && strlen(cur_resolver) != 0) {
+    gpr_log(GPR_INFO, "Warning: overriding resolver setting of %s",
+            cur_resolver);
+  }
+  if (gpr_stricmp(resolver_type, "native") == 0) {
+    gpr_setenv("GRPC_DNS_RESOLVER", "native");
+  } else if (gpr_stricmp(resolver_type, "ares") == 0) {
+    gpr_setenv("GRPC_DNS_RESOLVER", "ares");
+  } else {
+    gpr_log(GPR_ERROR, "--resolver_type was not set to ares or native");
+    abort();
+  }
   grpc::testing::TestEnvironment env(argc, argv);
   grpc_init();
 
   {
     grpc_core::ExecCtx exec_ctx;
-    char* resolver_env = gpr_getenv("GRPC_DNS_RESOLVER");
+    test_named_and_numeric_scope_ids();
     // c-ares resolver doesn't support UDS (ability for native DNS resolver
     // to handle this is only expected to be used by servers, which
     // unconditionally use the native DNS resolver).
+    char* resolver_env = gpr_getenv("GRPC_DNS_RESOLVER");
     if (resolver_env == nullptr || gpr_stricmp(resolver_env, "native") == 0) {
       test_unix_socket();
       test_unix_socket_path_name_too_long();
     }
     gpr_free(resolver_env);
   }
+  gpr_cmdline_destroy(cl);
 
   grpc_shutdown();
   return 0;