diff options
author | David Garcia Quintas <dgq@google.com> | 2016-11-01 04:09:05 +0100 |
---|---|---|
committer | David Garcia Quintas <dgq@google.com> | 2016-10-31 22:31:51 -0700 |
commit | 7ec291330c4442bc2d4adc1f93ff8f7bd9149c14 (patch) | |
tree | 8aac999ab7df467cd9d63abbbbb4c33f4e05de36 /test/cpp | |
parent | 6cb547443b7674279a069f51481cc7b30193c6da (diff) |
PR comments
Diffstat (limited to 'test/cpp')
-rw-r--r-- | test/cpp/grpclb/grpclb_test.cc | 16 |
1 files changed, 14 insertions, 2 deletions
diff --git a/test/cpp/grpclb/grpclb_test.cc b/test/cpp/grpclb/grpclb_test.cc index b6056f9ae4..3a92eb56b7 100644 --- a/test/cpp/grpclb/grpclb_test.cc +++ b/test/cpp/grpclb/grpclb_test.cc @@ -76,10 +76,22 @@ extern "C" { // - Send a serverlist with faulty ip:port addresses (port > 2^16, etc). // - Test reception of invalid serverlist // - Test pinging -// - Test against a non-LB server. That server should return UNIMPLEMENTED and -// the call should fail. +// - Test against a non-LB server. // - Random LB server closing the stream unexpectedly. // - Test using DNS-resolvable names (localhost?) +// +// Findings from end to end testing to be covered here: +// - Handling of LB servers restart, including reconnection after backing-off +// retries. +// - Destruction of load balanced channel (and therefore of grpclb instance) +// while: +// 1) the internal LB call is still active. This should work by virtue +// of the weak reference the LB call holds. The call should be terminated as +// part of the grpclb shutdown process. +// 2) the retry timer is active. Again, the weak reference it holds should +// prevent a premature call to \a glb_destroy. +// - Restart of backend servers with no changes to serverlist. This exercises +// the RR handover mechanism. namespace grpc { namespace { |