diff options
author | David G. Quintas <dgq@google.com> | 2016-11-02 08:12:52 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2016-11-02 08:12:52 +0100 |
commit | 105b39450aa03a55af537a4a85220e7bf5e48f70 (patch) | |
tree | 118fbdeca68ed5fb83536a3a3b9b02e173265ce4 /test/cpp | |
parent | 00bbb4122a8875876eb3075c32585fe296d5ba85 (diff) | |
parent | 6e7baf75dd8ab88d452e7001c41699857afd6e98 (diff) |
Merge pull request #8568 from dgquintas/grpclb_leaks_fix
gRPC LB fixes from end two end testing
Diffstat (limited to 'test/cpp')
-rw-r--r-- | test/cpp/grpclb/grpclb_test.cc | 16 |
1 files changed, 14 insertions, 2 deletions
diff --git a/test/cpp/grpclb/grpclb_test.cc b/test/cpp/grpclb/grpclb_test.cc index d788240438..c796e55e1a 100644 --- a/test/cpp/grpclb/grpclb_test.cc +++ b/test/cpp/grpclb/grpclb_test.cc @@ -76,10 +76,22 @@ extern "C" { // - Send a serverlist with faulty ip:port addresses (port > 2^16, etc). // - Test reception of invalid serverlist // - Test pinging -// - Test against a non-LB server. That server should return UNIMPLEMENTED and -// the call should fail. +// - Test against a non-LB server. // - Random LB server closing the stream unexpectedly. // - Test using DNS-resolvable names (localhost?) +// +// Findings from end to end testing to be covered here: +// - Handling of LB servers restart, including reconnection after backing-off +// retries. +// - Destruction of load balanced channel (and therefore of grpclb instance) +// while: +// 1) the internal LB call is still active. This should work by virtue +// of the weak reference the LB call holds. The call should be terminated as +// part of the grpclb shutdown process. +// 2) the retry timer is active. Again, the weak reference it holds should +// prevent a premature call to \a glb_destroy. +// - Restart of backend servers with no changes to serverlist. This exercises +// the RR handover mechanism. namespace grpc { namespace { |