aboutsummaryrefslogtreecommitdiffhomepage
path: root/test/cpp/util/metrics_server.cc
diff options
context:
space:
mode:
authorGravatar Sree Kuchibhotla <sreek@google.com>2015-11-16 11:52:54 -0800
committerGravatar Sree Kuchibhotla <sreek@google.com>2015-11-16 14:41:04 -0800
commitb047c0fc9b455e6cbfd1d6b080e9bb427282b670 (patch)
tree6c8bd8598bfe51607fda1f7c92e5e04ee9de096b /test/cpp/util/metrics_server.cc
parentc36b480ce9354daaaf829de88a0a04e76873df7a (diff)
Address code review comments
Diffstat (limited to 'test/cpp/util/metrics_server.cc')
-rw-r--r--test/cpp/util/metrics_server.cc12
1 files changed, 6 insertions, 6 deletions
diff --git a/test/cpp/util/metrics_server.cc b/test/cpp/util/metrics_server.cc
index eac29f3093..5bb87e53f1 100644
--- a/test/cpp/util/metrics_server.cc
+++ b/test/cpp/util/metrics_server.cc
@@ -61,8 +61,8 @@ grpc::Status MetricsServiceImpl::GetAllGauges(
std::lock_guard<std::mutex> lock(mu_);
for (auto it = gauges_.begin(); it != gauges_.end(); it++) {
GaugeResponse resp;
- resp.set_name(it->first); // Gauge name
- resp.set_value(it->second->Get()); // Gauge value
+ resp.set_name(it->first); // Gauge name
+ resp.set_long_value(it->second->Get()); // Gauge value
writer->Write(resp);
}
@@ -77,14 +77,14 @@ grpc::Status MetricsServiceImpl::GetGauge(ServerContext* context,
auto it = gauges_.find(request->name());
if (it != gauges_.end()) {
response->set_name(it->first);
- response->set_value(it->second->Get());
+ response->set_long_value(it->second->Get());
}
return Status::OK;
}
-std::shared_ptr<Gauge> MetricsServiceImpl::CreateGauge(string name,
- bool& already_present) {
+std::shared_ptr<Gauge> MetricsServiceImpl::CreateGauge(const grpc::string& name,
+ bool* already_present) {
std::lock_guard<std::mutex> lock(mu_);
std::shared_ptr<Gauge> gauge(new Gauge(0));
@@ -92,7 +92,7 @@ std::shared_ptr<Gauge> MetricsServiceImpl::CreateGauge(string name,
// p.first is an iterator pointing to <name, shared_ptr<Gauge>> pair. p.second
// is a boolean indicating if the Gauge is already present in the map
- already_present = !p.second;
+ *already_present = !p.second;
return p.first->second;
}