diff options
| author |  apolcyn <apolcyn@google.com> | 2017-01-17 17:30:41 -0800 |
|---|---|---|
| committer |  GitHub <noreply@github.com> | 2017-01-17 17:30:41 -0800 |
| commit | 44e907af0e61feec0357bea9dfd745046126f2da (patch) | |
| tree | a050fec1193c4b2fbf99c0ab6795bbac8e228c68 /test/cpp/qps/qps_json_driver.cc | |
| parent | fc4b07e10c0482522dbc6a01401ea8f1606a76b4 (diff) | |
| parent | 62a7ca8c9516b071593e7cea63d3466678589085 (diff) | |
Merge pull request #9322 from apolcyn/deprecate_benchmark_core_lists
Don't configure core lists in in benchmark driver
Diffstat (limited to 'test/cpp/qps/qps_json_driver.cc')
| -rw-r--r-- | test/cpp/qps/qps_json_driver.cc | 15 |
1 files changed, 6 insertions, 9 deletions
diff --git a/test/cpp/qps/qps_json_driver.cc b/test/cpp/qps/qps_json_driver.cc index 57ee5ef63c..ddaaa7ca75 100644 --- a/test/cpp/qps/qps_json_driver.cc +++ b/test/cpp/qps/qps_json_driver.cc @@ -70,9 +70,6 @@ DEFINE_double(error_tolerance, 0.01, DEFINE_string(qps_server_target_override, "", "Override QPS server target to configure in client configs." "Only applicable if there is a single benchmark server."); -DEFINE_bool(configure_core_lists, true, - "Provide 'core_list' parameters to workers. Value determined " - "by cores available and 'core_limit' parameters of the scenarios."); namespace grpc { namespace testing { @@ -80,12 +77,12 @@ namespace testing { static std::unique_ptr<ScenarioResult> RunAndReport(const Scenario& scenario, bool* success) { std::cerr << "RUNNING SCENARIO: " << scenario.name() << "\n"; - auto result = RunScenario( - scenario.client_config(), scenario.num_clients(), - scenario.server_config(), scenario.num_servers(), - scenario.warmup_seconds(), scenario.benchmark_seconds(), - scenario.spawn_local_worker_count(), - FLAGS_qps_server_target_override.c_str(), FLAGS_configure_core_lists); + auto result = + RunScenario(scenario.client_config(), scenario.num_clients(), + scenario.server_config(), scenario.num_servers(), + scenario.warmup_seconds(), scenario.benchmark_seconds(), + scenario.spawn_local_worker_count(), + FLAGS_qps_server_target_override.c_str()); // Amend the result with scenario config. Eventually we should adjust // RunScenario contract so we don't need to touch the result here. |