aboutsummaryrefslogtreecommitdiffhomepage
path: root/test/cpp/microbenchmarks
diff options
context:
space:
mode:
authorGravatar Sheena Madan <43831800+sheenaqotj@users.noreply.github.com>2018-12-05 18:41:39 -0800
committerGravatar GitHub <noreply@github.com>2018-12-05 18:41:39 -0800
commit58745066550ad84e30d04e2c27678f7ba38b73c4 (patch)
treeb3b229a09907cebf2bc21ac933c0d19395143d10 /test/cpp/microbenchmarks
parentcf7f6dadcccf6ffb0399fe95246f61fc9c966520 (diff)
parent8a461613d1ac867310558e03f5856fdb771c319a (diff)
Merge pull request #17418 from grpc/revert-16882-microbenchmarks-bazel
Revert "Make Microbenchmarks Test Targets"
Diffstat (limited to 'test/cpp/microbenchmarks')
-rw-r--r--test/cpp/microbenchmarks/BUILD53
-rw-r--r--test/cpp/microbenchmarks/bm_call_create.cc2
2 files changed, 21 insertions, 34 deletions
diff --git a/test/cpp/microbenchmarks/BUILD b/test/cpp/microbenchmarks/BUILD
index 84ea386870..5ae9a9a791 100644
--- a/test/cpp/microbenchmarks/BUILD
+++ b/test/cpp/microbenchmarks/BUILD
@@ -46,55 +46,51 @@ grpc_cc_library(
],
)
-grpc_cc_test(
+grpc_cc_binary(
name = "bm_closure",
+ testonly = 1,
srcs = ["bm_closure.cc"],
deps = [":helpers"],
- uses_polling = False,
)
-# TODO(https://github.com/grpc/grpc/pull/16882): make this a test target
-# right now it OOMs
grpc_cc_binary(
name = "bm_arena",
srcs = ["bm_arena.cc"],
deps = [":helpers"],
)
-grpc_cc_test(
+grpc_cc_binary(
name = "bm_channel",
+ testonly = 1,
srcs = ["bm_channel.cc"],
deps = [":helpers"],
- uses_polling = False,
)
-# TODO(https://github.com/grpc/grpc/pull/16882): make this a test target
-# right now it fails UBSAN
grpc_cc_binary(
name = "bm_call_create",
srcs = ["bm_call_create.cc"],
deps = [":helpers"],
)
-grpc_cc_test(
+grpc_cc_binary(
name = "bm_cq",
+ testonly = 1,
srcs = ["bm_cq.cc"],
deps = [":helpers"],
- uses_polling = False,
)
-grpc_cc_test(
+grpc_cc_binary(
name = "bm_cq_multiple_threads",
+ testonly = 1,
srcs = ["bm_cq_multiple_threads.cc"],
deps = [":helpers"],
- uses_polling = False,
)
-grpc_cc_test(
+grpc_cc_binary(
name = "bm_error",
+ testonly = 1,
srcs = ["bm_error.cc"],
deps = [":helpers"],
- uses_polling = False,
)
grpc_cc_library(
@@ -105,8 +101,9 @@ grpc_cc_library(
deps = [":helpers"],
)
-grpc_cc_test(
+grpc_cc_binary(
name = "bm_fullstack_streaming_ping_pong",
+ testonly = 1,
srcs = [
"bm_fullstack_streaming_ping_pong.cc",
],
@@ -121,8 +118,9 @@ grpc_cc_library(
deps = [":helpers"],
)
-grpc_cc_test(
+grpc_cc_binary(
name = "bm_fullstack_streaming_pump",
+ testonly = 1,
srcs = [
"bm_fullstack_streaming_pump.cc",
],
@@ -143,38 +141,27 @@ grpc_cc_library(
deps = [":helpers"],
)
-grpc_cc_test(
+grpc_cc_binary(
name = "bm_fullstack_unary_ping_pong",
+ testonly = 1,
srcs = [
"bm_fullstack_unary_ping_pong.cc",
],
deps = [":fullstack_unary_ping_pong_h"],
)
-grpc_cc_test(
+grpc_cc_binary(
name = "bm_metadata",
+ testonly = 1,
srcs = ["bm_metadata.cc"],
deps = [":helpers"],
- uses_polling = False,
)
-grpc_cc_test(
+grpc_cc_binary(
name = "bm_chttp2_hpack",
+ testonly = 1,
srcs = ["bm_chttp2_hpack.cc"],
deps = [":helpers"],
- uses_polling = False,
-)
-
-grpc_cc_test(
- name = "bm_chttp2_transport",
- srcs = ["bm_chttp2_transport.cc"],
- deps = [":helpers"],
-)
-
-grpc_cc_test(
- name = "bm_pollset",
- srcs = ["bm_pollset.cc"],
- deps = [":helpers"],
)
grpc_cc_binary(
diff --git a/test/cpp/microbenchmarks/bm_call_create.cc b/test/cpp/microbenchmarks/bm_call_create.cc
index a0157c66c2..8d12606434 100644
--- a/test/cpp/microbenchmarks/bm_call_create.cc
+++ b/test/cpp/microbenchmarks/bm_call_create.cc
@@ -526,7 +526,7 @@ static void BM_IsolatedFilter(benchmark::State& state) {
grpc_core::ExecCtx exec_ctx;
size_t channel_size = grpc_channel_stack_size(
- filters.size() == 0 ? nullptr : filters.data(), filters.size());
+ filters.size() == 0 ? nullptr : &filters[0], filters.size());
grpc_channel_stack* channel_stack =
static_cast<grpc_channel_stack*>(gpr_zalloc(channel_size));
GPR_ASSERT(GRPC_LOG_IF_ERROR(