aboutsummaryrefslogtreecommitdiffhomepage
path: root/test/cpp/microbenchmarks/bm_call_create.cc
diff options
context:
space:
mode:
authorGravatar Mark D. Roth <roth@google.com>2018-06-13 14:49:25 -0700
committerGravatar GitHub <noreply@github.com>2018-06-13 14:49:25 -0700
commit0159026111b4dac15ddd228baee3757554898235 (patch)
treeee14b853ed3196219b1a2b13b18cf0b5c929f73d /test/cpp/microbenchmarks/bm_call_create.cc
parent057fd3f57515e373ca4d220f48d1550c45eb7709 (diff)
Revert "Second attempt: move recv_trailing_metadata into its own callback, don't use on_complete for recv_ops"
Diffstat (limited to 'test/cpp/microbenchmarks/bm_call_create.cc')
-rw-r--r--test/cpp/microbenchmarks/bm_call_create.cc24
1 files changed, 8 insertions, 16 deletions
diff --git a/test/cpp/microbenchmarks/bm_call_create.cc b/test/cpp/microbenchmarks/bm_call_create.cc
index dd1610dc3d..831b29c506 100644
--- a/test/cpp/microbenchmarks/bm_call_create.cc
+++ b/test/cpp/microbenchmarks/bm_call_create.cc
@@ -621,26 +621,18 @@ typedef struct {
static void StartTransportStreamOp(grpc_call_element* elem,
grpc_transport_stream_op_batch* op) {
call_data* calld = static_cast<call_data*>(elem->call_data);
- // Construct list of closures to return.
- grpc_core::CallCombinerClosureList closures;
if (op->recv_initial_metadata) {
- closures.Add(op->payload->recv_initial_metadata.recv_initial_metadata_ready,
- GRPC_ERROR_NONE, "recv_initial_metadata");
+ GRPC_CALL_COMBINER_START(
+ calld->call_combiner,
+ op->payload->recv_initial_metadata.recv_initial_metadata_ready,
+ GRPC_ERROR_NONE, "recv_initial_metadata");
}
if (op->recv_message) {
- closures.Add(op->payload->recv_message.recv_message_ready, GRPC_ERROR_NONE,
- "recv_message");
+ GRPC_CALL_COMBINER_START(calld->call_combiner,
+ op->payload->recv_message.recv_message_ready,
+ GRPC_ERROR_NONE, "recv_message");
}
- if (op->recv_trailing_metadata) {
- closures.Add(
- op->payload->recv_trailing_metadata.recv_trailing_metadata_ready,
- GRPC_ERROR_NONE, "recv_trailing_metadata");
- }
- if (op->on_complete != nullptr) {
- closures.Add(op->on_complete, GRPC_ERROR_NONE, "on_complete");
- }
- // Execute closures.
- closures.RunClosures(calld->call_combiner);
+ GRPC_CLOSURE_SCHED(op->on_complete, GRPC_ERROR_NONE);
}
static void StartTransportOp(grpc_channel_element* elem,