diff options
author | Vijay Pai <vpai@google.com> | 2016-02-25 11:51:21 -0800 |
---|---|---|
committer | Vijay Pai <vpai@google.com> | 2016-02-25 11:51:21 -0800 |
commit | bdfec2c86ceba99e6cc3e58ee256dffe1632aaf4 (patch) | |
tree | 9c4e74f94cd3170a0be05423a2903718caaa670f /test/cpp/end2end | |
parent | f7806b766bf88d2173ef37a4205d1393bbd73d60 (diff) |
SimultaneousReadWritesDone test was not observing the contract on the
streaming API. In particular, Finish should not be called until the client
is sure that there is no more message to be read (as documented in
the comments for ClientStreamingInterface::Finish)
Diffstat (limited to 'test/cpp/end2end')
-rw-r--r-- | test/cpp/end2end/end2end_test.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/test/cpp/end2end/end2end_test.cc b/test/cpp/end2end/end2end_test.cc index ce8e4d2a10..42757974b2 100644 --- a/test/cpp/end2end/end2end_test.cc +++ b/test/cpp/end2end/end2end_test.cc @@ -904,9 +904,9 @@ TEST_P(End2endTest, SimultaneousReadWritesDone) { std::thread reader_thread(ReaderThreadFunc, stream.get(), &ev); gpr_event_wait(&ev, gpr_inf_future(GPR_CLOCK_REALTIME)); stream->WritesDone(); + reader_thread.join(); Status s = stream->Finish(); EXPECT_TRUE(s.ok()); - reader_thread.join(); } TEST_P(End2endTest, ChannelState) { |