aboutsummaryrefslogtreecommitdiffhomepage
path: root/test/cpp/end2end/channelz_service_test.cc
diff options
context:
space:
mode:
authorGravatar ncteisen <ncteisen@gmail.com>2018-09-10 14:03:40 -0700
committerGravatar ncteisen <ncteisen@gmail.com>2018-09-10 14:03:40 -0700
commit6ef3b0dc2b4d1c339a0a44b3c2e9f9f8654b7acf (patch)
treece7afae717479e9a2196ccdd96419fb9dff34e85 /test/cpp/end2end/channelz_service_test.cc
parentf1931ef624640fbeb8e113d2e64bf6162d4dc0a7 (diff)
parent107d10ea73f77dc9bb498c9b91e1fcd0188dfb45 (diff)
Merge branch 'master' of https://github.com/grpc/grpc into channelz-cpp-server
Diffstat (limited to 'test/cpp/end2end/channelz_service_test.cc')
-rw-r--r--test/cpp/end2end/channelz_service_test.cc9
1 files changed, 1 insertions, 8 deletions
diff --git a/test/cpp/end2end/channelz_service_test.cc b/test/cpp/end2end/channelz_service_test.cc
index 1f9b2e9616..e96d68f93b 100644
--- a/test/cpp/end2end/channelz_service_test.cc
+++ b/test/cpp/end2end/channelz_service_test.cc
@@ -375,7 +375,6 @@ TEST_F(ChannelzServerTest, ManySubchannels) {
SendFailedEcho(1);
SendFailedEcho(2);
}
-
GetTopChannelsRequest gtc_request;
GetTopChannelsResponse gtc_response;
gtc_request.set_start_channel_id(0);
@@ -384,11 +383,6 @@ TEST_F(ChannelzServerTest, ManySubchannels) {
channelz_stub_->GetTopChannels(&context, gtc_request, &gtc_response);
EXPECT_TRUE(s.ok()) << s.error_message();
EXPECT_EQ(gtc_response.channel_size(), kNumChannels);
-
- // std::string gtc_str;
- // google::protobuf::TextFormat::PrintToString(gtc_response, &gtc_str);
- // std::cout << "GetTopChannels:\n" << gtc_str << "\n";
-
for (int i = 0; i < gtc_response.channel_size(); ++i) {
// if the channel sent no RPCs, then expect no subchannels to have been
// created.
@@ -396,8 +390,7 @@ TEST_F(ChannelzServerTest, ManySubchannels) {
EXPECT_EQ(gtc_response.channel(i).subchannel_ref_size(), 0);
continue;
}
- // Since this is pick first, we know that there was only one subchannel
- // used. We request it here.
+ // The resolver must return at least one address.
ASSERT_GT(gtc_response.channel(i).subchannel_ref_size(), 0);
GetSubchannelRequest gsc_request;
GetSubchannelResponse gsc_response;