diff options
author | 2018-09-07 16:02:08 -0700 | |
---|---|---|
committer | 2018-09-07 16:02:08 -0700 | |
commit | 4205b97dd9e4f9e03ca4ce5f2d5bcfa6984a55eb (patch) | |
tree | bcbb764b326fa8142637c7b53db8f5d13ada3de9 /test/cpp/end2end/channelz_service_test.cc | |
parent | e165579d3e9e40c5bef77f775fac9e0860a1c527 (diff) |
reviewer feedback
Diffstat (limited to 'test/cpp/end2end/channelz_service_test.cc')
-rw-r--r-- | test/cpp/end2end/channelz_service_test.cc | 9 |
1 files changed, 1 insertions, 8 deletions
diff --git a/test/cpp/end2end/channelz_service_test.cc b/test/cpp/end2end/channelz_service_test.cc index 504eb8441e..7fe8083251 100644 --- a/test/cpp/end2end/channelz_service_test.cc +++ b/test/cpp/end2end/channelz_service_test.cc @@ -360,7 +360,6 @@ TEST_F(ChannelzServerTest, ManySubchannels) { SendFailedEcho(1); SendFailedEcho(2); } - GetTopChannelsRequest gtc_request; GetTopChannelsResponse gtc_response; gtc_request.set_start_channel_id(0); @@ -369,11 +368,6 @@ TEST_F(ChannelzServerTest, ManySubchannels) { channelz_stub_->GetTopChannels(&context, gtc_request, >c_response); EXPECT_TRUE(s.ok()) << s.error_message(); EXPECT_EQ(gtc_response.channel_size(), kNumChannels); - - // std::string gtc_str; - // google::protobuf::TextFormat::PrintToString(gtc_response, >c_str); - // std::cout << "GetTopChannels:\n" << gtc_str << "\n"; - for (int i = 0; i < gtc_response.channel_size(); ++i) { // if the channel sent no RPCs, then expect no subchannels to have been // created. @@ -381,8 +375,7 @@ TEST_F(ChannelzServerTest, ManySubchannels) { EXPECT_EQ(gtc_response.channel(i).subchannel_ref_size(), 0); continue; } - // Since this is pick first, we know that there was only one subchannel - // used. We request it here. + // The resolver must return at least one address. ASSERT_GT(gtc_response.channel(i).subchannel_ref_size(), 0); GetSubchannelRequest gsc_request; GetSubchannelResponse gsc_response; |