diff options
| author |  Harvey Tuch <htuch@google.com> | 2017-01-20 11:02:11 -0500 |
|---|---|---|
| committer | Harvey Tuch <htuch@google.com> | 2017-02-07 15:45:44 -0500 |
| commit | 5f3cfe960f708a397c4465a3064072dd3b2d7bb7 (patch) | |
| tree | 363b85675839116c4314dbff8548170d94031acf /test/cpp/codegen/codegen_test_full.cc | |
| parent | 27ee9d015dff36ebf32e95c80a4d0b37ac7137ba (diff) | |
Fix read from uninitialized memory bug in GrpcBufferWriter.
This commit fixes an issue in which the following sequence of operations
leads to use of uninitialized memory:
1. Caller invokes GrpcBufferWriter::Next(), and then makes use of 8191
bytes in the returned buffer (which is 8192 bytes in size).
2. Caller then returns the unused single byte via
GrpcBufferWriter::BackUp(). This method invokes
g_core_codegen_interface->grpc_slice_split_tail(), which causes
backup_slice_ to be a grpc_slice with one byte.
3. At the next invocation of GrpcBufferWriter::Next(), a reference to
the single byte grpc_slice is returned to the caller.
The problem here is that the returned reference is to the inlined buffer
in the grpc_slice, which is resident in slice_, not the location of the
buffer inside slice_buffer_ after
g_core_codegen_interface->grpc_slice_buffer_add() in
GrpcBufferWriter::Next(). As a result, any data the caller writes to the
returned void* data is lost.
The solution is to avoid inlined backup slices.
Diffstat (limited to 'test/cpp/codegen/codegen_test_full.cc')
| -rw-r--r-- | test/cpp/codegen/codegen_test_full.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/test/cpp/codegen/codegen_test_full.cc b/test/cpp/codegen/codegen_test_full.cc index d6e2416b55..bc19fc9669 100644 --- a/test/cpp/codegen/codegen_test_full.cc +++ b/test/cpp/codegen/codegen_test_full.cc @@ -1,6 +1,6 @@ /* * - * Copyright 2016, Google Inc. + * Copyright 2017, Google Inc. * All rights reserved. * * Redistribution and use in source and binary forms, with or without |