aboutsummaryrefslogtreecommitdiffhomepage
path: root/test/core
diff options
context:
space:
mode:
authorGravatar Vijay Pai <vpai@google.com>2018-02-20 14:27:35 -0800
committerGravatar Vijay Pai <vpai@google.com>2018-02-20 14:31:31 -0800
commitc02d997607f155d39382cce26d10583f2b0fefba (patch)
tree49dd755bf61bb760ed45394d11e153987420c7fb /test/core
parentc3e5c56d1a2163b688cc8b8c62595633f220b756 (diff)
Minor bug fixes
Diffstat (limited to 'test/core')
-rw-r--r--test/core/gpr/BUILD10
-rw-r--r--test/core/gprpp/BUILD10
-rw-r--r--test/core/iomgr/ev_epollsig_linux_test.cc5
3 files changed, 13 insertions, 12 deletions
diff --git a/test/core/gpr/BUILD b/test/core/gpr/BUILD
index 9aa74cc132..9bd4c2feff 100644
--- a/test/core/gpr/BUILD
+++ b/test/core/gpr/BUILD
@@ -119,16 +119,6 @@ grpc_cc_test(
)
grpc_cc_test(
- name = "thd_test",
- srcs = ["thd_test.cc"],
- language = "C++",
- deps = [
- "//:gpr",
- "//test/core/util:gpr_test_util",
- ],
-)
-
-grpc_cc_test(
name = "time_test",
srcs = ["time_test.cc"],
language = "C++",
diff --git a/test/core/gprpp/BUILD b/test/core/gprpp/BUILD
index 1c11e0bdb5..9eff49e6c0 100644
--- a/test/core/gprpp/BUILD
+++ b/test/core/gprpp/BUILD
@@ -94,3 +94,13 @@ grpc_cc_test(
"gtest",
],
)
+
+grpc_cc_test(
+ name = "thd_test",
+ srcs = ["thd_test.cc"],
+ language = "C++",
+ deps = [
+ "//:gpr",
+ "//test/core/util:gpr_test_util",
+ ],
+)
diff --git a/test/core/iomgr/ev_epollsig_linux_test.cc b/test/core/iomgr/ev_epollsig_linux_test.cc
index 3a41c48b2f..e3ee67e023 100644
--- a/test/core/iomgr/ev_epollsig_linux_test.cc
+++ b/test/core/iomgr/ev_epollsig_linux_test.cc
@@ -22,6 +22,7 @@
#include "src/core/lib/iomgr/ev_epollsig_linux.h"
#include "src/core/lib/iomgr/ev_posix.h"
+#include <new>
#include <errno.h>
#include <string.h>
#include <unistd.h>
@@ -260,7 +261,7 @@ static void test_threading(void) {
grpc_pollset_init(shared.pollset, &shared.mu);
grpc_core::Thread thds[10];
- for (auto& th: thds) {
+ for (auto& th : thds) {
new (&th) grpc_core::Thread("test_thread", test_threading_loop, &shared);
th.Start();
}
@@ -279,7 +280,7 @@ static void test_threading(void) {
}
GPR_ASSERT(GRPC_LOG_IF_ERROR("wakeup_first",
grpc_wakeup_fd_wakeup(shared.wakeup_fd)));
- for (auto& th: thds) {
+ for (auto& th : thds) {
th.Join();
}
fd.read_fd = 0;