diff options
| author |  Adele Zhou <adelez@google.com> | 2017-11-29 14:37:18 -0800 |
|---|---|---|
| committer | Adele Zhou <adelez@google.com> | 2017-11-30 17:10:28 -0800 |
| commit | e5df91f477a27ce71a39bca928677b2f08649615 (patch) | |
| tree | e07c0034feae455bcac7fff11dabdcc0304a3bf0 /test/core/util | |
| parent | c8bf2da1e0f36fe3a6f271140153fad8e9df8dbd (diff) | |
Use select to decide the test is hermetic or not
Diffstat (limited to 'test/core/util')
| -rw-r--r-- | test/core/util/BUILD | 3 | ||||
| -rw-r--r-- | test/core/util/port_hermetic.cc | 4 |
2 files changed, 4 insertions, 3 deletions
diff --git a/test/core/util/BUILD b/test/core/util/BUILD index 9884e04627..f92c0ff548 100644 --- a/test/core/util/BUILD +++ b/test/core/util/BUILD @@ -74,9 +74,6 @@ grpc_cc_library( "tracer_util.h", "trickle_endpoint.h", ], - defines = [ - "GRPC_HERMETIC_TESTS=1", - ], language = "C++", deps = [ ":gpr_test_util", diff --git a/test/core/util/port_hermetic.cc b/test/core/util/port_hermetic.cc index 3650816763..b4d097f650 100644 --- a/test/core/util/port_hermetic.cc +++ b/test/core/util/port_hermetic.cc @@ -16,6 +16,10 @@ * */ +/* When running tests hermeticly, i.e. running on remote machines, + * the framework takes a round-robin pick of a port within certain range. + * There is no need to recycle ports. + */ #include "src/core/lib/iomgr/port.h" #include "test/core/util/test_config.h" #if defined(GRPC_HERMETIC_TESTS) |