diff options
author | ncteisen <ncteisen@gmail.com> | 2017-11-16 09:02:58 -0800 |
---|---|---|
committer | ncteisen <ncteisen@gmail.com> | 2017-11-16 09:02:58 -0800 |
commit | b2aa06ae990e82b5c7f573f282b7bcfef7093d54 (patch) | |
tree | 3823d5a2c06eb094ac2b9f3fc57fd704ff0937bf /test/core/util | |
parent | 9006013267a00f214390e8a0cfc6311d8e999f17 (diff) |
Reviewer feedback: friend func not clasS
Diffstat (limited to 'test/core/util')
-rw-r--r-- | test/core/util/tracer_peer.cc | 20 | ||||
-rw-r--r-- | test/core/util/tracer_peer.h | 5 |
2 files changed, 9 insertions, 16 deletions
diff --git a/test/core/util/tracer_peer.cc b/test/core/util/tracer_peer.cc index 6c18430f89..acb770515f 100644 --- a/test/core/util/tracer_peer.cc +++ b/test/core/util/tracer_peer.cc @@ -21,21 +21,11 @@ #include "src/core/lib/debug/trace.h" namespace grpc_core { - -// This class is a friend of TraceFlag, and can be used to manually turn on -// certain tracers for tests. -class TraceFlagPeer { - public: - TraceFlagPeer(TraceFlag* flag) : flag_(flag) {} - void enable() { flag_->set_enabled(1); } - void disable() { flag_->set_enabled(0); } - - private: - TraceFlag* flag_; -}; -} // namespace grpc_core +namespace testing { void grpc_tracer_peer_enable_flag(grpc_core::TraceFlag* flag) { - grpc_core::TraceFlagPeer peer(flag); - peer.enable(); + flag->set_enabled(1); } + +} // namespace testing +} // namespace grpc_core diff --git a/test/core/util/tracer_peer.h b/test/core/util/tracer_peer.h index e8a5f6c31a..0b6c6dd685 100644 --- a/test/core/util/tracer_peer.h +++ b/test/core/util/tracer_peer.h @@ -21,9 +21,12 @@ namespace grpc_core { class TraceFlag; -} +namespace testing { // enables the TraceFlag passed to it. Used for testing purposes. void grpc_tracer_peer_enable_flag(grpc_core::TraceFlag* flag); +} // namespace testing +} // namespace grpc_core + #endif /* GRPC_TEST_CORE_UTIL_TRACER_PEER_H */ |