aboutsummaryrefslogtreecommitdiffhomepage
path: root/test/core/transport
diff options
context:
space:
mode:
authorGravatar Mark D. Roth <roth@google.com>2017-11-29 11:34:58 -0800
committerGravatar Mark D. Roth <roth@google.com>2017-11-29 11:34:58 -0800
commitca014e4d5ef0fd72bd9b0b72c427572b85dc795e (patch)
treea57c396b5442583a06f7098055ab40fcc1217e1c /test/core/transport
parent39dd9aa4393a32ff2334b3b6313ec5c2f71c8954 (diff)
Clean up semantics of test code.
Diffstat (limited to 'test/core/transport')
-rw-r--r--test/core/transport/chttp2/settings_timeout_test.cc6
1 files changed, 3 insertions, 3 deletions
diff --git a/test/core/transport/chttp2/settings_timeout_test.cc b/test/core/transport/chttp2/settings_timeout_test.cc
index a1e748d21c..670eae1f79 100644
--- a/test/core/transport/chttp2/settings_timeout_test.cc
+++ b/test/core/transport/chttp2/settings_timeout_test.cc
@@ -122,8 +122,8 @@ class Client {
}
// Reads until an error is returned.
- // Returns false if no error is returned by the deadline.
- bool Read() {
+ // Returns true if an error was encountered before the deadline.
+ bool ReadUntilError() {
grpc_exec_ctx exec_ctx = GRPC_EXEC_CTX_INIT;
grpc_slice_buffer read_buffer;
grpc_slice_buffer_init(&read_buffer);
@@ -233,7 +233,7 @@ TEST(SettingsTimeout, Basic) {
client.Connect();
// Client read. Should fail due to server dropping connection.
gpr_log(GPR_INFO, "starting client read");
- EXPECT_TRUE(client.Read());
+ EXPECT_TRUE(client.ReadUntilError());
// Shut down client.
gpr_log(GPR_INFO, "shutting down client");
client.Shutdown();