aboutsummaryrefslogtreecommitdiffhomepage
path: root/test/core/slice
diff options
context:
space:
mode:
authorGravatar Yash Tibrewal <yashkt@google.com>2017-11-13 15:37:58 -0800
committerGravatar Yash Tibrewal <yashkt@google.com>2017-11-14 01:36:28 -0800
commit75122c23578e24417dcf64081c737571a9fc2dbc (patch)
treef4b8491964ec0508a5826490628c9f87b82c3326 /test/core/slice
parent36cd68f0d543b9024c84eff82319890a791de7f6 (diff)
Address some PR comments
Diffstat (limited to 'test/core/slice')
-rw-r--r--test/core/slice/b64_test.cc5
-rw-r--r--test/core/slice/slice_hash_table_test.cc3
2 files changed, 1 insertions, 7 deletions
diff --git a/test/core/slice/b64_test.cc b/test/core/slice/b64_test.cc
index 3f1de9bc12..5ed9910740 100644
--- a/test/core/slice/b64_test.cc
+++ b/test/core/slice/b64_test.cc
@@ -51,7 +51,7 @@ static void test_simple_encode_decode_b64(int url_safe, int multiline) {
GRPC_SLICE_LENGTH(hello_slice)) == 0);
grpc_slice_unref_internal(hello_slice);
- grpc_exec_ctx_finish();
+
gpr_free(hello_b64);
}
@@ -72,7 +72,6 @@ static void test_full_range_encode_decode_b64(int url_safe, int multiline) {
sizeof(orig) - i));
grpc_slice_unref_internal(orig_decoded);
gpr_free(b64);
- grpc_exec_ctx_finish();
}
}
@@ -128,7 +127,6 @@ static void test_url_safe_unsafe_mismatch_failure(void) {
GPR_ASSERT(GRPC_SLICE_IS_EMPTY(orig_decoded));
gpr_free(b64);
grpc_slice_unref_internal(orig_decoded);
- grpc_exec_ctx_finish();
}
static void test_rfc4648_test_vectors(void) {
@@ -199,7 +197,6 @@ static void test_unpadded_decode(void) {
decoded = grpc_base64_decode("", 0);
GPR_ASSERT(GRPC_SLICE_IS_EMPTY(decoded));
- grpc_exec_ctx_finish();
}
int main(int argc, char** argv) {
diff --git a/test/core/slice/slice_hash_table_test.cc b/test/core/slice/slice_hash_table_test.cc
index b5b9c1bb73..89fc33a7bf 100644
--- a/test/core/slice/slice_hash_table_test.cc
+++ b/test/core/slice/slice_hash_table_test.cc
@@ -121,7 +121,6 @@ static void test_slice_hash_table() {
// Clean up.
ExecCtx _local_exec_ctx;
grpc_slice_hash_table_unref(table);
- grpc_exec_ctx_finish();
}
static int value_cmp_fn(void* a, void* b) {
@@ -150,7 +149,6 @@ static void test_slice_hash_table_eq() {
ExecCtx _local_exec_ctx;
grpc_slice_hash_table_unref(table_a);
grpc_slice_hash_table_unref(table_b);
- grpc_exec_ctx_finish();
}
static void test_slice_hash_table_not_eq() {
@@ -229,7 +227,6 @@ static void test_slice_hash_table_not_eq() {
grpc_slice_hash_table_unref(table_f);
grpc_slice_hash_table_unref(table_g);
grpc_slice_hash_table_unref(table_h);
- grpc_exec_ctx_finish();
}
int main(int argc, char** argv) {