diff options
author | Mark D. Roth <roth@google.com> | 2018-07-27 08:20:31 -0700 |
---|---|---|
committer | Mark D. Roth <roth@google.com> | 2018-07-27 08:20:31 -0700 |
commit | 3abd6201342c321c106ed50699e78090c9e3e497 (patch) | |
tree | 7aee4ffd19e752bb7902f6790ad48c22a77a9d60 /test/core/gprpp | |
parent | 326f82e5e25a8144cc0566cf2cf61bcdc0cd25f4 (diff) |
fix clang_tidy
Diffstat (limited to 'test/core/gprpp')
-rw-r--r-- | test/core/gprpp/ref_counted_ptr_test.cc | 12 |
1 files changed, 8 insertions, 4 deletions
diff --git a/test/core/gprpp/ref_counted_ptr_test.cc b/test/core/gprpp/ref_counted_ptr_test.cc index 1e030c5ba3..463b5e8966 100644 --- a/test/core/gprpp/ref_counted_ptr_test.cc +++ b/test/core/gprpp/ref_counted_ptr_test.cc @@ -185,10 +185,6 @@ class Subclass : public BaseClass { Subclass() {} }; -void FunctionTakingBaseClass(RefCountedPtr<BaseClass> p) {} - -void FunctionTakingSubclass(RefCountedPtr<Subclass> p) {} - TEST(RefCountedPtr, ConstructFromSubclass) { RefCountedPtr<BaseClass> p(New<Subclass>()); } @@ -222,11 +218,19 @@ TEST(RefCountedPtr, EqualityWithSubclass) { EXPECT_EQ(b, s); } +void FunctionTakingBaseClass(RefCountedPtr<BaseClass> p) { + p.reset(); // To appease clang-tidy. +} + TEST(RefCountedPtr, CanPassSubclassToFunctionExpectingBaseClass) { RefCountedPtr<Subclass> p = MakeRefCounted<Subclass>(); FunctionTakingBaseClass(p); } +void FunctionTakingSubclass(RefCountedPtr<Subclass> p) { + p.reset(); // To appease clang-tidy. +} + TEST(RefCountedPtr, CanPassSubclassToFunctionExpectingSubclass) { RefCountedPtr<Subclass> p = MakeRefCounted<Subclass>(); FunctionTakingSubclass(p); |