aboutsummaryrefslogtreecommitdiffhomepage
path: root/test/core/compression
diff options
context:
space:
mode:
authorGravatar Craig Tiller <ctiller@google.com>2016-11-21 13:46:31 -0800
committerGravatar Craig Tiller <ctiller@google.com>2016-11-21 13:46:31 -0800
commit3b05e1da916aa298fe58a58ec79a7f7c043534c7 (patch)
tree72353f42667b389f913e6a5164019199000eded7 /test/core/compression
parent73ee7dc5590447bc726f7a1c3e51c2a217c8d5b6 (diff)
Move from cmp --> eq, and provide a good implementation for interning
Diffstat (limited to 'test/core/compression')
-rw-r--r--test/core/compression/algorithm_test.c20
-rw-r--r--test/core/compression/message_compress_test.c2
2 files changed, 10 insertions, 12 deletions
diff --git a/test/core/compression/algorithm_test.c b/test/core/compression/algorithm_test.c
index fa0bdb8c19..37397ced8d 100644
--- a/test/core/compression/algorithm_test.c
+++ b/test/core/compression/algorithm_test.c
@@ -61,13 +61,11 @@ static void test_algorithm_mesh(void) {
grpc_slice_from_static_string(name), &parsed));
GPR_ASSERT((int)parsed == i);
mdstr = grpc_slice_from_copied_string(name);
- GPR_ASSERT(0 ==
- grpc_slice_cmp(mdstr, grpc_compression_algorithm_slice(parsed)));
+ GPR_ASSERT(grpc_slice_eq(mdstr, grpc_compression_algorithm_slice(parsed)));
GPR_ASSERT(parsed == grpc_compression_algorithm_from_slice(mdstr));
mdelem = grpc_compression_encoding_mdelem(parsed);
- GPR_ASSERT(0 == grpc_slice_cmp(GRPC_MDVALUE(mdelem), mdstr));
- GPR_ASSERT(0 ==
- grpc_slice_cmp(GRPC_MDKEY(mdelem), GRPC_MDSTR_GRPC_ENCODING));
+ GPR_ASSERT(grpc_slice_eq(GRPC_MDVALUE(mdelem), mdstr));
+ GPR_ASSERT(grpc_slice_eq(GRPC_MDKEY(mdelem), GRPC_MDSTR_GRPC_ENCODING));
grpc_slice_unref_internal(&exec_ctx, mdstr);
GRPC_MDELEM_UNREF(&exec_ctx, mdelem);
grpc_exec_ctx_finish(&exec_ctx);
@@ -91,12 +89,12 @@ static void test_algorithm_failure(void) {
mdstr = grpc_slice_from_static_string("this-is-an-invalid-algorithm");
GPR_ASSERT(grpc_compression_algorithm_from_slice(mdstr) ==
GRPC_COMPRESS_ALGORITHMS_COUNT);
- GPR_ASSERT(0 == grpc_slice_cmp(grpc_compression_algorithm_slice(
- GRPC_COMPRESS_ALGORITHMS_COUNT),
- grpc_empty_slice()));
- GPR_ASSERT(0 == grpc_slice_cmp(grpc_compression_algorithm_slice(
- GRPC_COMPRESS_ALGORITHMS_COUNT + 1),
- grpc_empty_slice()));
+ GPR_ASSERT(grpc_slice_eq(
+ grpc_compression_algorithm_slice(GRPC_COMPRESS_ALGORITHMS_COUNT),
+ grpc_empty_slice()));
+ GPR_ASSERT(grpc_slice_eq(
+ grpc_compression_algorithm_slice(GRPC_COMPRESS_ALGORITHMS_COUNT + 1),
+ grpc_empty_slice()));
grpc_slice_unref_internal(&exec_ctx, mdstr);
grpc_exec_ctx_finish(&exec_ctx);
}
diff --git a/test/core/compression/message_compress_test.c b/test/core/compression/message_compress_test.c
index 2432ca768a..246a2b3a71 100644
--- a/test/core/compression/message_compress_test.c
+++ b/test/core/compression/message_compress_test.c
@@ -114,7 +114,7 @@ static void assert_passthrough(grpc_slice value,
}
final = grpc_slice_merge(output.slices, output.count);
- GPR_ASSERT(0 == grpc_slice_cmp(value, final));
+ GPR_ASSERT(grpc_slice_eq(value, final));
grpc_slice_buffer_destroy(&input);
grpc_slice_buffer_destroy(&compressed);