aboutsummaryrefslogtreecommitdiffhomepage
path: root/test/core/client_channel
diff options
context:
space:
mode:
authorGravatar Mark D. Roth <roth@google.com>2018-08-20 12:30:28 -0700
committerGravatar Mark D. Roth <roth@google.com>2018-08-20 12:30:28 -0700
commitba4f66e705d149a4f30993befb4d6d5825b13841 (patch)
treedd7471c4b4e2cf826d5b6958751138fee462d7d7 /test/core/client_channel
parent4eceb65aaad6d01a1c2ca66cf9ab95c22d75a502 (diff)
Allow more timing slack in dns cooldown test.
Diffstat (limited to 'test/core/client_channel')
-rw-r--r--test/core/client_channel/resolvers/dns_resolver_cooldown_test.cc7
1 files changed, 5 insertions, 2 deletions
diff --git a/test/core/client_channel/resolvers/dns_resolver_cooldown_test.cc b/test/core/client_channel/resolvers/dns_resolver_cooldown_test.cc
index 27de7cac95..1a7db40f59 100644
--- a/test/core/client_channel/resolvers/dns_resolver_cooldown_test.cc
+++ b/test/core/client_channel/resolvers/dns_resolver_cooldown_test.cc
@@ -29,6 +29,8 @@
#include "test/core/util/test_config.h"
constexpr int kMinResolutionPeriodMs = 1000;
+// Provide some slack when checking intervals, to allow for test timing issues.
+constexpr int kMinResolutionPeriodForCheckMs = 900;
extern grpc_address_resolver_vtable* grpc_resolve_address_impl;
static grpc_address_resolver_vtable* default_resolve_address;
@@ -70,7 +72,7 @@ static void test_resolve_address_impl(const char* name,
} else {
grpc_millis now =
grpc_timespec_to_millis_round_up(gpr_now(GPR_CLOCK_MONOTONIC));
- GPR_ASSERT(now - last_resolution_time >= kMinResolutionPeriodMs);
+ GPR_ASSERT(now - last_resolution_time >= kMinResolutionPeriodForCheckMs);
last_resolution_time = now;
}
}
@@ -96,11 +98,12 @@ static grpc_ares_request* test_dns_lookup_ares_locked(
++g_resolution_count;
static grpc_millis last_resolution_time = 0;
if (last_resolution_time == 0) {
+ last_resolution_time =
grpc_timespec_to_millis_round_up(gpr_now(GPR_CLOCK_MONOTONIC));
} else {
grpc_millis now =
grpc_timespec_to_millis_round_up(gpr_now(GPR_CLOCK_MONOTONIC));
- GPR_ASSERT(now - last_resolution_time >= kMinResolutionPeriodMs);
+ GPR_ASSERT(now - last_resolution_time >= kMinResolutionPeriodForCheckMs);
last_resolution_time = now;
}
return result;