diff options
| author |  Matt Kwong <mattkwong@google.com> | 2018-05-04 12:00:25 -0700 |
|---|---|---|
| committer | Matt Kwong <mattkwong@google.com> | 2018-05-04 16:16:29 -0700 |
| commit | fcd04ec121664de621ceb874c44eab5fbdc6bbd7 (patch) | |
| tree | 2bf84940cd17ecf4aa31b63744ace38da1f90b5c /templates/tools | |
| parent | d5f659a2d265931f86aef3c92ad7a977c3bae8a5 (diff) | |
Remove the fallback when creating Python virtual env
See https://github.com/grpc/grpc/issues/15253 for more context. The
original behavior when running Python tests is to try to create a
virtual env with the specifed Python version. If there is an issue
with that, fallback to the system's default Python version. This leads to
misleading test results, so removing the fallback and failing the test
when virtual env fails to instantiate the specified Python version is
the new behavior.
Diffstat (limited to 'templates/tools')
| -rw-r--r-- | templates/tools/dockerfile/test/python_jessie_x64/Dockerfile.template | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/templates/tools/dockerfile/test/python_jessie_x64/Dockerfile.template b/templates/tools/dockerfile/test/python_jessie_x64/Dockerfile.template index dba6a227f2..e73b839a28 100644 --- a/templates/tools/dockerfile/test/python_jessie_x64/Dockerfile.template +++ b/templates/tools/dockerfile/test/python_jessie_x64/Dockerfile.template @@ -19,6 +19,10 @@ <%include file="../../apt_get_basic.include"/> <%include file="../../gcp_api_libraries.include"/> <%include file="../../python_deps.include"/> + # Install pip and virtualenv for Python 3.4 + RUN curl https://bootstrap.pypa.io/get-pip.py | python3.4 + RUN python3.4 -m pip install virtualenv + <%include file="../../run_tests_addons.include"/> # Define the default command. CMD ["bash"] |