diff options
| author |  Paul Marks <paul@pmarks.net> | 2016-11-30 20:01:54 -0800 |
|---|---|---|
| committer |  GitHub <noreply@github.com> | 2016-11-30 20:01:54 -0800 |
| commit | b1c4e619dec0f10581b23818b33c00484b681153 (patch) | |
| tree | aaacf40b0058cb4487abfe066beb664a86aa0d39 /src | |
| parent | 9832b9b2de8ce14dbce90d4cc90336984e8d83c3 (diff) | |
| parent | 83b6e8e6152dd04e35d3221ecaa108f48c7e07a5 (diff) | |
Merge pull request #8849 from pmarks-net/master
Fix a memory leak in grpc_udp_server_add_port()
Diffstat (limited to 'src')
| -rw-r--r-- | src/core/lib/iomgr/udp_server.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/src/core/lib/iomgr/udp_server.c b/src/core/lib/iomgr/udp_server.c index fd0c7a0f9d..3c24ea9afa 100644 --- a/src/core/lib/iomgr/udp_server.c +++ b/src/core/lib/iomgr/udp_server.c @@ -388,7 +388,8 @@ int grpc_udp_server_add_port(grpc_udp_server *s, /* Try listening on IPv6 first. */ addr = &wild6; // TODO(rjshade): Test and propagate the returned grpc_error*: - grpc_create_dualstack_socket(addr, SOCK_DGRAM, IPPROTO_UDP, &dsmode, &fd); + GRPC_ERROR_UNREF(grpc_create_dualstack_socket(addr, SOCK_DGRAM, IPPROTO_UDP, + &dsmode, &fd)); allocated_port1 = add_socket_to_server(s, fd, addr, read_cb, orphan_cb); if (fd >= 0 && dsmode == GRPC_DSMODE_DUALSTACK) { goto done; @@ -402,7 +403,8 @@ int grpc_udp_server_add_port(grpc_udp_server *s, } // TODO(rjshade): Test and propagate the returned grpc_error*: - grpc_create_dualstack_socket(addr, SOCK_DGRAM, IPPROTO_UDP, &dsmode, &fd); + GRPC_ERROR_UNREF(grpc_create_dualstack_socket(addr, SOCK_DGRAM, IPPROTO_UDP, + &dsmode, &fd)); if (fd < 0) { gpr_log(GPR_ERROR, "Unable to create socket: %s", strerror(errno)); } |