diff options
author | Yuchen Zeng <zyc@google.com> | 2017-03-17 13:42:27 -0700 |
---|---|---|
committer | Yuchen Zeng <zyc@google.com> | 2017-03-17 16:00:20 -0700 |
commit | 8c87db0ddd19df8fefacae51d95c58a135864b13 (patch) | |
tree | bfa736b539a06759cd049643f2dedbfb0bd4ad7e /src | |
parent | 4a769943ddbe3264089c4f051e48ed45b9c2087f (diff) |
Add TODOs to track unimplmented features
Diffstat (limited to 'src')
-rw-r--r-- | src/core/ext/resolver/dns/c_ares/grpc_ares_wrapper.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/core/ext/resolver/dns/c_ares/grpc_ares_wrapper.c b/src/core/ext/resolver/dns/c_ares/grpc_ares_wrapper.c index 77f87c8a57..f077e1b091 100644 --- a/src/core/ext/resolver/dns/c_ares/grpc_ares_wrapper.c +++ b/src/core/ext/resolver/dns/c_ares/grpc_ares_wrapper.c @@ -98,6 +98,7 @@ static void grpc_ares_request_unref(grpc_exec_ctx *exec_ctx, // If there are no pending queries, invoke on_done callback and destroy the // request if (gpr_unref(&r->pending_queries)) { + // TODO(zyc): Sort results with RPC6724 before invoking on_done. if (exec_ctx == NULL) { // A new exec_ctx is created here, as the c-ares interface does not // provide one in ares_host_callback. It's safe to schedule on_done with @@ -240,6 +241,7 @@ void grpc_resolve_address_ares_impl(grpc_exec_ctx *exec_ctx, const char *name, ares_gethostbyname(*channel, r->host, AF_INET6, on_done_cb, r); } ares_gethostbyname(*channel, r->host, AF_INET, on_done_cb, r); + // TODO(zyc): Handle CNAME records here. grpc_ares_ev_driver_start(exec_ctx, r->ev_driver); grpc_ares_request_unref(exec_ctx, r); return; |