aboutsummaryrefslogtreecommitdiffhomepage
path: root/src
diff options
context:
space:
mode:
authorGravatar Lidi Zheng <scallopsky@gmail.com>2018-11-06 17:05:55 -0800
committerGravatar GitHub <noreply@github.com>2018-11-06 17:05:55 -0800
commit88150dbe2cc8251b2b2cc7152d0364a3a54cad53 (patch)
tree06d435591de2760bfa525e2ddd1594d1ecddcb33 /src
parent193b4b57ec8ec1509a91069f8cdd1ba1917b2d71 (diff)
parent03841be6ce220c9b0d5f9f7e6c673337611c9739 (diff)
Merge pull request #17128 from lidizheng/add-comment-to-commands-py
Add background about gRPC Python's building process on macOS
Diffstat (limited to 'src')
-rw-r--r--src/python/grpcio/commands.py6
1 files changed, 6 insertions, 0 deletions
diff --git a/src/python/grpcio/commands.py b/src/python/grpcio/commands.py
index 3cb0eb179e..dc6779740f 100644
--- a/src/python/grpcio/commands.py
+++ b/src/python/grpcio/commands.py
@@ -253,6 +253,12 @@ class BuildExt(build_ext.build_ext):
LINK_OPTIONS = {}
def build_extensions(self):
+ # This special conditioning is here due to difference of compiler
+ # behavior in gcc and clang. The clang doesn't take --stdc++11
+ # flags but gcc does. Since the setuptools of Python only support
+ # all C or all C++ compilation, the mix of C and C++ will crash.
+ # *By default*, the macOS use clang and Linux use gcc, that's why
+ # the special condition here is checking platform.
if "darwin" in sys.platform:
config = os.environ.get('CONFIG', 'opt')
target_path = os.path.abspath(