diff options
author | Abhishek Kumar <abhikumar@google.com> | 2015-07-14 10:53:12 -0700 |
---|---|---|
committer | Abhishek Kumar <abhikumar@google.com> | 2015-07-14 10:53:12 -0700 |
commit | 1cbeeb508b033c84f73ec79756bb4f7c0227a0d0 (patch) | |
tree | 2950ac8e89aec58f395ccacb53491d497188e6b8 /src/ruby/lib | |
parent | 707dd2c36f83377ca6f5c389ff1f6af8062af87c (diff) | |
parent | f88eecd80d501f91a36922d3514bad94a21b5c22 (diff) |
Merge pull request #2336 from murgatroid99/ruby_error_codes
Made ruby server return correct error code for unimplemented method
Diffstat (limited to 'src/ruby/lib')
-rw-r--r-- | src/ruby/lib/grpc/generic/rpc_server.rb | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/src/ruby/lib/grpc/generic/rpc_server.rb b/src/ruby/lib/grpc/generic/rpc_server.rb index a7e20d6b82..67bf35ce02 100644 --- a/src/ruby/lib/grpc/generic/rpc_server.rb +++ b/src/ruby/lib/grpc/generic/rpc_server.rb @@ -398,14 +398,14 @@ module GRPC nil end - # Sends NOT_FOUND if the method can't be found - def found?(an_rpc) + # Sends UNIMPLEMENTED if the method is not implemented by this server + def implemented?(an_rpc) mth = an_rpc.method.to_sym return an_rpc if rpc_descs.key?(mth) - GRPC.logger.warn("NOT_FOUND: #{an_rpc}") + GRPC.logger.warn("UNIMPLEMENTED: #{an_rpc}") noop = proc { |x| x } c = ActiveCall.new(an_rpc.call, @cq, noop, noop, an_rpc.deadline) - c.send_status(StatusCodes::NOT_FOUND, '') + c.send_status(StatusCodes::UNIMPLEMENTED, '') nil end @@ -446,7 +446,7 @@ module GRPC an_rpc.call.run_batch(@cq, handle_call_tag, INFINITE_FUTURE, SEND_INITIAL_METADATA => connect_md) return nil unless available?(an_rpc) - return nil unless found?(an_rpc) + return nil unless implemented?(an_rpc) # Create the ActiveCall GRPC.logger.info("deadline is #{an_rpc.deadline}; (now=#{Time.now})") |