aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/ruby/ext/grpc/rb_channel.c
diff options
context:
space:
mode:
authorGravatar Alexander Polcyn <apolcyn@google.com>2017-03-13 12:00:42 -0700
committerGravatar Alexander Polcyn <apolcyn@google.com>2017-03-13 12:00:42 -0700
commit69719089da708a4630a792131e8cf1ee579e15d5 (patch)
treeda5abd339eb667d0cde59359c2964b1191c080db /src/ruby/ext/grpc/rb_channel.c
parentb7e1f535f3af352dfb708fd3261314f3333a70f1 (diff)
remove a TODO
Diffstat (limited to 'src/ruby/ext/grpc/rb_channel.c')
-rw-r--r--src/ruby/ext/grpc/rb_channel.c7
1 files changed, 3 insertions, 4 deletions
diff --git a/src/ruby/ext/grpc/rb_channel.c b/src/ruby/ext/grpc/rb_channel.c
index ccdca15c98..9a3f82c2b7 100644
--- a/src/ruby/ext/grpc/rb_channel.c
+++ b/src/ruby/ext/grpc/rb_channel.c
@@ -416,10 +416,10 @@ static void grpc_rb_channel_safe_destroy(grpc_rb_channel *wrapper) {
grpc_channel_destroy(wrapper->wrapped);
}
-// Note this loop breaks out when a single call of
+// Note this loop breaks out with a single call of
// "grpc_rb_event_unblocking_func".
-// TODO (apolcyn) does a ruby call to the unblocking func
-// necesarily mean process shutdown?
+// This assumes that a ruby call the unblocking func
+// indicates process shutdown.
// In the worst case, this stops polling channel connectivity
// early and falls back to current behavior.
static void *run_poll_channels_loop_no_gil(void *arg) {
@@ -430,7 +430,6 @@ static void *run_poll_channels_loop_no_gil(void *arg) {
event = grpc_completion_queue_next(
channel_polling_cq, gpr_inf_future(GPR_CLOCK_REALTIME), NULL);
if (event.type == GRPC_QUEUE_SHUTDOWN) {
- // TODO (apolcyn) is it guaranteed that this cq is empty by now?
break;
}
if (event.type == GRPC_OP_COMPLETE) {