aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/python/grpcio_tests/tests/unit/_metadata_test.py
diff options
context:
space:
mode:
authorGravatar Nathaniel Manista <nathaniel@google.com>2018-03-13 16:28:11 +0000
committerGravatar Nathaniel Manista <nathaniel@google.com>2018-03-13 21:59:54 +0000
commit7726c303a65fe344bf45866e919f9980f05b40e3 (patch)
tree7d0cd93dba9ca7ffb31d5adabe29af43a733b64a /src/python/grpcio_tests/tests/unit/_metadata_test.py
parent44fd6557aefad4689eac7225386aecefd1f9a5bc (diff)
Verify early OK behavior
Looks like early OK support was implemented in https://github.com/grpc/grpc/pull/14080 but https://github.com/grpc/grpc/issues/7032 was not marked fixed at the time. Good thing it was just an idea on our Google Summer of Code ideas page...
Diffstat (limited to 'src/python/grpcio_tests/tests/unit/_metadata_test.py')
-rw-r--r--src/python/grpcio_tests/tests/unit/_metadata_test.py9
1 files changed, 2 insertions, 7 deletions
diff --git a/src/python/grpcio_tests/tests/unit/_metadata_test.py b/src/python/grpcio_tests/tests/unit/_metadata_test.py
index 5908421011..2309eeb733 100644
--- a/src/python/grpcio_tests/tests/unit/_metadata_test.py
+++ b/src/python/grpcio_tests/tests/unit/_metadata_test.py
@@ -117,9 +117,6 @@ def handle_stream_unary(test, request_iterator, servicer_context):
validate_client_metadata(test, servicer_context)
servicer_context.send_initial_metadata(_INITIAL_METADATA)
servicer_context.set_trailing_metadata(_TRAILING_METADATA)
- # TODO(issue:#6891) We should be able to remove this loop
- for request in request_iterator:
- pass
return _RESPONSE
@@ -127,10 +124,8 @@ def handle_stream_stream(test, request_iterator, servicer_context):
validate_client_metadata(test, servicer_context)
servicer_context.send_initial_metadata(_INITIAL_METADATA)
servicer_context.set_trailing_metadata(_TRAILING_METADATA)
- # TODO(issue:#6891) We should be able to remove this loop,
- # and replace with return; yield
- for request in request_iterator:
- yield _RESPONSE
+ return
+ yield
class _MethodHandler(grpc.RpcMethodHandler):