aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/objective-c
diff options
context:
space:
mode:
authorGravatar Muxi Yan <mxyan@google.com>2016-10-17 10:39:32 -0700
committerGravatar Muxi Yan <mxyan@google.com>2016-10-17 10:39:32 -0700
commit44b673c76334152a514f5c6b1e9ff516f805a9c8 (patch)
treea8d9a1f92c2508527355b5bfde54dfde520ba95e /src/objective-c
parenta79de37daf214d415372751fe35ae362772c393e (diff)
Remove makarandd's TODO hack
Diffstat (limited to 'src/objective-c')
-rw-r--r--src/objective-c/tests/CoreCronetEnd2EndTests/CoreCronetEnd2EndTests.m23
1 files changed, 9 insertions, 14 deletions
diff --git a/src/objective-c/tests/CoreCronetEnd2EndTests/CoreCronetEnd2EndTests.m b/src/objective-c/tests/CoreCronetEnd2EndTests/CoreCronetEnd2EndTests.m
index d5d8d230a0..e50f66d9d9 100644
--- a/src/objective-c/tests/CoreCronetEnd2EndTests/CoreCronetEnd2EndTests.m
+++ b/src/objective-c/tests/CoreCronetEnd2EndTests/CoreCronetEnd2EndTests.m
@@ -124,20 +124,6 @@ static void chttp2_tear_down_secure_fullstack(grpc_end2end_test_fixture *f) {
static void cronet_init_client_simple_ssl_secure_fullstack(
grpc_end2end_test_fixture *f, grpc_channel_args *client_args) {
- static bool done = false;
- // TODO (makdharma): DO NOT CHECK IN THIS HACK!!!
- if (!done) {
- done = true;
- [Cronet setHttp2Enabled:YES];
- [Cronet setQuicEnabled:YES];
- [Cronet enableTestCertVerifierForTesting];
- NSURL *url = [[[NSFileManager defaultManager]
- URLsForDirectory:NSDocumentDirectory
- inDomains:NSUserDomainMask] lastObject];
- NSLog(@"Documents directory: %@", url);
- [Cronet start];
- [Cronet startNetLogToFile:@"Documents/cronet_netlog.json" logBytes:YES];
- }
cronet_engine *cronetEngine = [Cronet getGlobalEngine];
grpc_channel_args *new_client_args = grpc_channel_args_copy(client_args);
@@ -210,6 +196,15 @@ static char *roots_filename;
gpr_setenv(GRPC_DEFAULT_SSL_ROOTS_FILE_PATH_ENV_VAR, roots_filename);
grpc_init();
+
+ [Cronet setHttp2Enabled:YES];
+ [Cronet enableTestCertVerifierForTesting];
+ NSURL *url = [[[NSFileManager defaultManager]
+ URLsForDirectory:NSDocumentDirectory
+ inDomains:NSUserDomainMask] lastObject];
+ NSLog(@"Documents directory: %@", url);
+ [Cronet start];
+ [Cronet startNetLogToFile:@"Documents/cronet_netlog.json" logBytes:YES];
}
// The tearDown() function is run after all test cases finish running