aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/objective-c/RxLibrary
diff options
context:
space:
mode:
authorGravatar Muxi Yan <mxyan@google.com>2019-01-09 09:38:47 -0800
committerGravatar Muxi Yan <mxyan@google.com>2019-01-09 09:38:47 -0800
commitd4fa274bf2994276341e47920aa46e7a009b4d10 (patch)
tree149815a6421a2317600d2274c562fea01192dfa2 /src/objective-c/RxLibrary
parent0c4c2de427399fe260aeaa2140638825fa43f26b (diff)
address comments
Diffstat (limited to 'src/objective-c/RxLibrary')
-rw-r--r--src/objective-c/RxLibrary/GRXConcurrentWriteable.m6
-rw-r--r--src/objective-c/RxLibrary/GRXWriter.h2
2 files changed, 3 insertions, 5 deletions
diff --git a/src/objective-c/RxLibrary/GRXConcurrentWriteable.m b/src/objective-c/RxLibrary/GRXConcurrentWriteable.m
index d8491d2aed..115195463d 100644
--- a/src/objective-c/RxLibrary/GRXConcurrentWriteable.m
+++ b/src/objective-c/RxLibrary/GRXConcurrentWriteable.m
@@ -113,10 +113,8 @@
- (void)cancelSilently {
dispatch_async(_writeableQueue, ^{
- @synchronized(self) {
- if (self->_alreadyFinished) {
- return;
- }
+ if (self->_alreadyFinished) {
+ return;
}
self.writeable = nil;
});
diff --git a/src/objective-c/RxLibrary/GRXWriter.h b/src/objective-c/RxLibrary/GRXWriter.h
index ac1f7b9c4c..df4c80c28d 100644
--- a/src/objective-c/RxLibrary/GRXWriter.h
+++ b/src/objective-c/RxLibrary/GRXWriter.h
@@ -82,7 +82,7 @@ typedef NS_ENUM(NSInteger, GRXWriterState) {
* the corresponding value, and that's useful for advanced use cases like pausing an writer. For
* more details, see the documentation of the enum further down. The property is thread safe.
*/
-@property(atomic) GRXWriterState state;
+@property GRXWriterState state;
/**
* Transition to the Started state, and start sending messages to the writeable (a reference to it