aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/objective-c/GRPCClient/private/GRPCHost.m
diff options
context:
space:
mode:
authorGravatar Muxi Yan <mxyan@google.com>2018-09-18 18:05:38 -0700
committerGravatar Muxi Yan <mxyan@google.com>2018-09-18 18:11:45 -0700
commit6a75d93e91070821eb5346008d55ae505a925652 (patch)
treed89f1a46f03a4fb47918a3e198cace69f70853b3 /src/objective-c/GRPCClient/private/GRPCHost.m
parentd177c8fe46c2550133199f71714c23ff0df8d38a (diff)
Fix analyze issues in gRPC ObjC lib
Diffstat (limited to 'src/objective-c/GRPCClient/private/GRPCHost.m')
-rw-r--r--src/objective-c/GRPCClient/private/GRPCHost.m9
1 files changed, 6 insertions, 3 deletions
diff --git a/src/objective-c/GRPCClient/private/GRPCHost.m b/src/objective-c/GRPCClient/private/GRPCHost.m
index 862909f238..6953efd03f 100644
--- a/src/objective-c/GRPCClient/private/GRPCHost.m
+++ b/src/objective-c/GRPCClient/private/GRPCHost.m
@@ -69,7 +69,7 @@ static NSMutableDictionary *kHostCache;
// gRPC library.
// TODO(jcanizales): Add unit tests for the types of addresses we want to let pass untouched.
NSURL *hostURL = [NSURL URLWithString:[@"https://" stringByAppendingString:address]];
- if (hostURL.host && !hostURL.port) {
+ if (hostURL.host && hostURL.port == nil) {
address = [hostURL.host stringByAppendingString:@":443"];
}
@@ -137,7 +137,10 @@ static NSMutableDictionary *kHostCache;
completionQueue:queue];
}
-- (NSData *)nullTerminatedDataWithString:(NSString *)string {
+- (NSData *)nullTerminatedDataWithString:(NSString *_Nullable)string {
+ if (string == nil) {
+ return nil;
+ }
// dataUsingEncoding: does not return a null-terminated string.
NSData *data = [string dataUsingEncoding:NSASCIIStringEncoding allowLossyConversion:YES];
NSMutableData *nullTerminated = [NSMutableData dataWithData:data];
@@ -226,7 +229,7 @@ static NSMutableDictionary *kHostCache;
args[@GRPC_SSL_TARGET_NAME_OVERRIDE_ARG] = _hostNameOverride;
}
- if (_responseSizeLimitOverride) {
+ if (_responseSizeLimitOverride != nil) {
args[@GRPC_ARG_MAX_RECEIVE_MESSAGE_LENGTH] = _responseSizeLimitOverride;
}