diff options
| author |  Jorge Canizales <jcanizales@google.com> | 2015-08-08 16:29:52 -0700 |
|---|---|---|
| committer | Jorge Canizales <jcanizales@google.com> | 2015-08-08 16:48:47 -0700 |
| commit | 297ed7bd81ba5a8e607f278713fb0facc9475b91 (patch) | |
| tree | 98425c74de8bcfbffb18e532a454008446f8a401 /src/objective-c/GRPCClient/GRPCCall.m | |
| parent | eb87b4653a40ee9e6226687ec3f9306c0b9a89df (diff) | |
Don’t set the request writer to nil, as @synchr(nil) is undefined behavior.
Also clarify in GRXWriter.h that the writeable is released whenever the
writer finishes.
Diffstat (limited to 'src/objective-c/GRPCClient/GRPCCall.m')
| -rw-r--r-- | src/objective-c/GRPCClient/GRPCCall.m | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/src/objective-c/GRPCClient/GRPCCall.m b/src/objective-c/GRPCClient/GRPCCall.m index 405f0335e7..6836d34394 100644 --- a/src/objective-c/GRPCClient/GRPCCall.m +++ b/src/objective-c/GRPCClient/GRPCCall.m @@ -150,7 +150,6 @@ NSString * const kGRPCStatusMetadataKey = @"io.grpc.StatusMetadataKey"; // If there were still request messages coming, stop them. @synchronized(_requestWriter) { _requestWriter.state = GRXWriterStateFinished; - _requestWriter = nil; } if (errorOrNil) { @@ -288,9 +287,6 @@ NSString * const kGRPCStatusMetadataKey = @"io.grpc.StatusMetadataKey"; } - (void)writesFinishedWithError:(NSError *)errorOrNil { - @synchronized(_requestWriter) { - _requestWriter = nil; - } if (errorOrNil) { [self cancel]; } else { |